manga-download / hakuneko

Manga & Anime Downloader for Linux, Windows & MacOS
https://hakuneko.download
The Unlicense
4.41k stars 453 forks source link

[Bug] magic scroll next chapter not working sometimes #2078

Closed Robonau closed 3 years ago

Robonau commented 3 years ago

Did you read the troubleshooting guide Yes

Describe the bug sometimes when getting to the bottom of a chapter with magic scroll it wont go to the next chapter (no matter how many time i press space)

To Reproduce Steps to reproduce the behavior:

  1. 1st kiss manga
  2. hardcore leveling warrior
  3. chapter 10
  4. using magic scroll won't take you to the end of the page, and thus wont go to the next chapter you have to scroll down a bit to use magic scroll to go the the next page

Expected behavior it take you to the end of the page and then to the next

Screenshots won't go to the next chapter and wont go to the end of it

will go to the next chapter

Context (please complete the following information):

Additional context im in portrait idk if that's gonna make a difference

Sheepux commented 3 years ago

Able to reproduce with that specific chapter. That's probably a pixel perfect case.

Robonau commented 3 years ago

it happens allot in that mahwa at least at the start

Robonau commented 3 years ago

im having it happen in other manhwa on different sites as well now (isekaiscan : magic emperor : chapter 106-8 possibly earlier ones)

Robonau commented 3 years ago

i think it happens whenever the top of the last page isn't on screen (have tested, it is this)(i tested by switching from portrait to landscape on the same manga and it worked on portrait but not landscape) which makes it just not work for most manga using landscape mode unless u zoom out a bunch

Sheepux commented 3 years ago

Ohhh, indeed. Thanks for the tests. That's going to be easier to fix.

Sheepux commented 3 years ago

Yep, pixel perfect case: "826.324 - 826 is not <0 " :D changing to <1

Robonau commented 3 years ago

that is an eerily similar fix to #1957 (changing a 0 to a 1 that is)