manga-download / hakuneko

Manga & Anime Downloader for Linux, Windows & MacOS
https://hakuneko.download
The Unlicense
4.79k stars 469 forks source link

[Feature]searching using the site search rather than filtering list #2814

Open Robonau opened 3 years ago

Robonau commented 3 years ago

Is your feature request related to a problem? Please describe. currently when you search for a manga by title you will only search through connectors you have a manga list for searching using the sites search would mean you can search through sites you haven't got a list for , it would also deal with alt names that manga have (HN currently just ignores alt names) (tachiyomi does this)

Describe the solution you'd like this would mostly be backend so this section is kinda useless but, a section of code in each connector that allows defining of a url to search from fetches is then returns a list of manga that were replied by the site

Describe alternatives you've considered loading the list for every connector, using tachiyomi

Context (please complete the following information):

Additional context this would mostly affect this section and not the list search, though it could(and maybe should) be extended to that

this could also be a replacement for those connectors that cant load a manga list

allot of sites have there search api respond with a json so it should be quite fast

i believe this would help with first time users allot too

i'm not suggesting to add this in to all existing connectors but to have an option to do it (and maybe some of the common templates (madara)) (madara would be: https://isekaiscan.com/wp-admin/admin-ajax.php POST with formdata 'action=wp-manga-search-manga&title=max' that would respond with an array of objects like (this could be changed in to whatever format u like (probably the same manga format as get manga list)) (i searched 'max') (connector search would just be if list.length then display connector)

Sheepux commented 3 years ago

To much additional work per connector. User can simply go to the website and use the copy paste feature. The "search" is actually a filter. Voting -no- for this one.

Robonau commented 3 years ago

dude its like 3 lines for each connector

note how like half of these are 3 lines https://gist.github.com/Robonau/2ff6f09bf6de503033a21914d7e6ccc3/raw/anime-planet%20link%20to%20other%20sites%20.user.js (with exceptions for sites with weird APIs)

Sheepux commented 3 years ago

feel free to code it if it's that easy.

Robonau commented 3 years ago

i mean ide be able to do the code per connector (the bit u were complaining about) i also said that this isn't something for every connector, just those that need it

but i got no idea where to start

Robonau commented 3 years ago

well im gonna attempt it

Robonau commented 3 years ago

attempt 1 https://github.com/Robonau/hakuneko/tree/searching-using-the-site-search

madara only (tested manga komi and isekai scan), everything else works as it did before

has issues with keeping the list when u go back to nothing breaks the Mangas: 100/100 at the bottom

can't change the list without saving it (idk how to avoid) so will be weird if u leave after searching something (u gotta search something then delete) breaks the loading thing as well