search

manga-download / hakuneko

Manga & Anime Downloader for Linux, Windows & MacOS
https://hakuneko.download
The Unlicense
4.62k stars 460 forks source link

[Feature] Option to disable Comicinfo file included in cbz download by default #6665

Open bangdosa93 opened 8 months ago

bangdosa93 commented 8 months ago

Did you read the troubleshooting guide Yes

Describe the bug A merge in the last week (https://github.com/manga-download/hakuneko/pull/6102) seems to have enabled comicinfo file being included in cbz downloads, but it seems to be enabled by default without any options to disable.

To Reproduce Steps to reproduce the behavior:

  1. have chapter file format as *cbz
  2. download any chapter,
  3. open the downloaded cbz file in any zip viewer
  4. comic info file is present

Expected behavior cbz files should not have comicinfo files being included enabled by default, and there should be an option in setting to enable or disable it

Screenshots expected option to show below chapter file format as shown in the merge image

What is seen in my hakuneko image

Context (please complete the following information):

Additional context

Sheepux commented 8 months ago

Not a bug but a feature enhancement request. It's been in nightly branch for 6 months

MikeZeDev commented 8 months ago

Any problem with that file?

bangdosa93 commented 8 months ago

the downloaded cbz file itself doesn't have problems in terms of usage, other than the comic info file being included.

From the messages in the merged pull request mentioned, it looked like including comic info file should have been defaulted to be not included, and there should have been a checkbox in the settings to enable or disable inclusion. But as mentioned, I didn't see the option in the settings.

Did I read it wrong?

Sheepux commented 8 months ago

This was changed after a review of the lead dev and the original title wasn't changed : https://github.com/manga-download/hakuneko/pull/6102#discussion_r1283825969

Sheepux commented 8 months ago

So the question is: is there a request (and a use case) for this to be optional ?

bangdosa93 commented 8 months ago

It would be nice for it to be optional, as I usually rename the files afterwards, and I'd like for the reader I use to show the file in the format I renamed to, but with the comicinfo file present, it takes the name as shown in the comicinfo file.

If it's too much of a bother, It's fine. I'll just try and figure out a way to remove or edit the comicinfo file when I rename cbz files.

Sheepux commented 8 months ago

Nah it's a valid request then. Could be easily integrated. @ronny1982, any second thoughts on that one ?

ronny1982 commented 8 months ago

I was hesitant to approve the mentioned PR since HakuNeko is actually feature complete, but was swayed by the effort the contributor put into.

Unfortunately now this leads to more maintenance work :(

Options:

I would prefer Leave as is.

Sheepux commented 8 months ago

I'd basically go with new setting with default settings enabled ("yes include commicbookinfo") meaning that for people that are unsatisfied by latest PR they still have an opt-out scenario

ronny1982 commented 8 months ago

Another idea would be to add a new format option