search

manga-download / hakuneko

Manga & Anime Downloader for Linux, Windows & MacOS
https://hakuneko.download
The Unlicense
4.69k stars 469 forks source link

Custom downloaders or parallel download #6890

Open Baerbeisser opened 7 months ago

Baerbeisser commented 7 months ago

Hello

I've seen that you are planning a big release this year, so maybe this point is already obsolete. Would it be possible to add an option for custom downloaders, like aria2? I realize that the pages have limits on their API's, so maybe with a big warning. Or alternatively, optional parallel download of chapters? Because the download speed each chapter is somewhat slow.

Context (please complete the following information): Version 6.17

edit: i see there's an opiton to disable concurrent downloads. But i see no concurrent downloads happening. Is this a premium feature? Or depending on the source?

MikeZeDev commented 7 months ago

1) There is no premium. Its free, we dont even accept donations.

2) Parallel downloads are a thing by default. It means for a given chapter all pages downloads are started at the same time (with a very little delay of 50ms). One chapter at a time, yup. Its not fully parallel, dont wanna stress servers too much

3) Its kinda pointless to ask here as downloads are reworked in the next version, a lot. With a download pool, stop, start, etc.. But its ok

4) The idea is not bad the thing is it has to be coded, maintained, and people will ask more and more questions because invariably download on many sites will fail with that method. We must be ready to tackle the added burden on support.

Baerbeisser commented 7 months ago

1.: Right, sorry. I confused "JPEG (premium only)" of some pages with premium of Hakuneko.

2.: like i said, i see only step-for-step per chapter. But maybe that's a restriction in the API of the pages i frequent? (mostly mangaread and mangakatana) Hakuneko from the AUR, btw, if that makes a difference.

4.: a warning in the settings and a Q/A is not enough? Wait, this is an Electron (or similiar) client? In this case forget it. And here i thought this app works similiar to youtube-dl and with a phontom-js equivalent.

MikeZeDev commented 6 months ago

@Sheepux i guess we already have something done/planned in Haruneko, i should close this right>?

Ohh sorry i tagged the wrong sheep :/

Sheepux commented 6 months ago

@Sheepux i guess we already have something done/planned in Haruneko, i should close this right>?

There is a better queuing system but even though parallel download could be coded i do believe that we wont implement it as a minimum respect to the content supplier. We're not planning to burden those websites.

Baerbeisser commented 6 months ago

Shouldn't this choice be left to the user, with default off for consideration?

Sheepux commented 6 months ago

It should be website opiniated, not user opiniated. Also, behavior related to increasing the parallelism would lead to possible extra issues and therefore more tickets. I vote for no (i'm not the only one to vote).