Use Node 20 for CI - Githubissues

manga-download / hakuneko

Manga & Anime Downloader for Linux, Windows & MacOS

https://hakuneko.download

The Unlicense

4.63k stars 461 forks source link

Use Node 20 for CI #7182

Closed MikeZeDev closed 3 months ago

MikeZeDev commented 3 months ago

Use last puppeteer version that support node 16. This will fix CI and let us use linter results.

ronny1982 commented 3 months ago

Any reason for sticking to Node 16 instead of Node 20? https://github.com/manga-download/hakuneko/blob/2d4a87298ec4b33419d934577fccb98328ecf4a1/.github/workflows/ci-pr.yml#L30 https://github.com/manga-download/hakuneko/blob/2d4a87298ec4b33419d934577fccb98328ecf4a1/.github/workflows/continuous-integration.yml#L31 https://github.com/manga-download/hakuneko/blob/2d4a87298ec4b33419d934577fccb98328ecf4a1/.github/workflows/continuous-deployment.yml#L25

MikeZeDev commented 3 months ago

I see no problem upgrading to 20, except it hasnt been tested. Not a big deal its just CI 🤷 The goal is to fix CI so we can still have lint checks.

Gotta give 20 a try

cloudflare-workers-and-pages[bot] commented 3 months ago

Deploying hakuneko with Cloudflare Pages

Latest commit:	`3ee0385`
Status:	✅ Deploy successful!
Preview URL:	https://a76d8506.hakuneko.pages.dev
Branch Preview URL:	https://puppeteer.hakuneko.pages.dev

View logs

ronny1982 commented 3 months ago

I see no problem upgrading to 20, except it hasnt been tested. Not a big deal its just CI 🤷 The goal is to fix CI so we can still have lint checks.

Gotta give 20 a try

I'm using Node 20.12 and have no issues so far with developing HakuNeko