search

manjaro / pamac

Graphical Package Manager for Manjaro Linux with Alpm, AUR, Appstream, Flatpak and Snap support
GNU General Public License v3.0
246 stars 42 forks source link

Use VTE widget for Details view #283

Open KSXGitHub opened 7 years ago

KSXGitHub commented 7 years ago

This is "Details view" that I'm refering to: image

The view above is fine until you install some electron-based application that use yarn to download dependencies (yarn will spam the terminal with pieces of broken progress bar). Beside, VTE interface is nicer.

guinux commented 7 years ago

Details view already uses a VTE widget. Can you give a example of AUR package which gives a strange output?

KSXGitHub commented 7 years ago

I don't remember which package gives the strange output because I saw it when I upgrade multiple packages. I believe strange output occurs when install some electron/nodejs packages that use yarn which prints progress bar when install dependencies. Yarn's progress bar looks pretty in genuine terminals (such as GNOME Terminal) but looks broken in pamac's details view.

BTW, this is a what yarn's progress bar looks like in normal terminals image

KSXGitHub commented 7 years ago

I just know which package have this problem! Open pamac and install webtorrent-desktop from AUR, you'll see the following pattern: line 58, line 65, line 67

image

Side note: webtorrent-desktop uses yarn to install its dependencies

guinux commented 7 years ago

I tested I don't have this issue.

KSXGitHub commented 7 years ago

@guinux What did you install? webtorrent-desktop or webtorrent-desktop-bin? Do you have yarn installed? (Without yarn, webtorrent-desktop might just use npm)

Video demo

guinux commented 7 years ago

Ok, I see the issue with webtorrent-desktop and yarn but for now I don't see how to fix it.