Closed AdrienWehrle closed 4 years ago
Hi Adriene - looks good but please make the following changes:
Add a note, comment, or documentation about the format of the CSV file. Is it lon, lat
or lat, lon
? And I assume decimal degrees? I don't know GeoJSON but if that is a loosely-defined format and I need to know that in order to use your code, let me know that too.
I think you can also squash multiple commits to one, so that the revisions history stays cleaner, but don't worry about this now.
I don't see any mention anywhere about (lon,lat) or (lat,lon) for CSV file. What documentation? Is a file missing from the commit?
Implementation proposal of a new condition to set footprint from a file containing desired coordinates (.csv and .geojson implemented), using boundary_from_file.py. Besides, footprints for different study areas have been hard-coded.