search

manolo / gwt-polymer-elements

Polymer Web Components for GWT. A collection of Material Design widgets for desktop and mobile.
Apache License 2.0
155 stars 49 forks source link

Grid example was using incorrect objects #139

Closed manolo closed 7 years ago

manolo commented 7 years ago

fixes #106

This change is Reviewable

platosha commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

demo/src/main/java/com/vaadin/polymer/demo/client/sampler/vaadin/VaadinGridSample.java, line 84 at r1 (raw file):

                // Reuse elements in the cell to improve performance
                HTMLElement e = (HTMLElement)c.getElement();
                IronIconElement elem = (IronIconElement)e.getFirstChild();

The names e and elem are confusingly similar, despite they are different elements and types.

Maybe rename elem to icon or iconEl to reduce confusion here?

Comments from Reviewable

manolo commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

demo/src/main/java/com/vaadin/polymer/demo/client/sampler/vaadin/VaadinGridSample.java, line 84 at r1 (raw file):

Previously, platosha (Anton Platonov) wrote… > The names `e` and `elem` are confusingly similar, despite they are different elements and types. > > Maybe rename `elem` to `icon` or `iconEl` to reduce confusion here?

Done.

Comments from Reviewable

platosha commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable