search

manolo / gwt-polymer-elements

Polymer Web Components for GWT. A collection of Material Design widgets for desktop and mobile.
Apache License 2.0
156 stars 49 forks source link

Overload getItem in vaadin-grid to handle two arguments callback. #140

Closed manolo closed 7 years ago

manolo commented 7 years ago

fixes #91

This change is Reviewable

platosha commented 7 years ago

Are you sure that this base class should be in the gwt-polymer-elements repo? If the elements package is produced in this repo, while the repo directory is used as a source at the same time, wouldn‘t there be conflicts and unnecessary overwrites in the matching file paths?

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

manolo commented 7 years ago

The gwt-api-generator expects *Base.java files placed in the lib folder of the package project. We used to have a couple of classes here some time ago until the original polymer element was fixed, that is the reason why the lib folder was empty. So the idea is that any user wanting to produce a library based on any 3rd party element could improve the defaults without having to patch the generator.

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

platosha commented 7 years ago

Good idea. :+1:

:lgtm_strong:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable