search

manolo / gwt-polymer-elements

Polymer Web Components for GWT. A collection of Material Design widgets for desktop and mobile.
Apache License 2.0
155 stars 49 forks source link

Fix fab, radio-button, radio-group, progress, menu #26

Closed cwayfinder closed 9 years ago

cwayfinder commented 9 years ago

Review on Reviewable

cwayfinder commented 9 years ago

Menu sample "before and after" http://screencast.com/t/gNl5UcCjXGl

Saulis commented 9 years ago

Reviewed 6 of 6 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

demo/src/main/java/com/vaadin/components/gwt/polymer/client/sampler/paper/FabSample.ui.xml, line 44 [r1] (raw file): Why not use with all elements?

Comments from the review on Reviewable.io

manolo commented 9 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

demo/src/main/java/com/vaadin/components/gwt/polymer/client/sampler/paper/FabSample.ui.xml, line 44 [r1] (raw file): Yes it should be done with all elements. This approach makes Java API register the element when the first paper-fab is instanciated, so the rest in the page takes advantage of the registration, but actually they are not using the java api at all, and could have problems with properties set previously to the custom element being available.

Comments from the review on Reviewable.io

manolo commented 9 years ago

Reviewed 6 of 6 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

Comments from the review on Reviewable.io