search

manolo / gwt-polymer-elements

Polymer Web Components for GWT. A collection of Material Design widgets for desktop and mobile.
Apache License 2.0
155 stars 49 forks source link

Fix/samples #27

Closed manolo closed 9 years ago

manolo commented 9 years ago

Review on Reviewable

Saulis commented 9 years ago

Review status: 0 of 8 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

demo/pom.xml, line 29 [r1] (raw file): What are we fetching from here?

demo/src/main/java/com/vaadin/components/gwt/polymer/client/sampler/paper/FabSample.ui.xml, line 43 [r1] (raw file): Are you guys doing the same things here with #26 ?

Comments from the review on Reviewable.io

manolo commented 9 years ago

Review status: 0 of 8 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

demo/pom.xml, line 29 [r1] (raw file): gwt-2.8.0-SNAPSHOT is under google repos not under default sonatype one

demo/src/main/java/com/vaadin/components/gwt/polymer/client/sampler/paper/FabSample.ui.xml, line 43 [r1] (raw file): Seems like Taras and me were working in the same cases, will coordinate with him

Comments from the review on Reviewable.io

cwayfinder commented 9 years ago

Reviewed 5 of 8 files at r1. Review status: 5 of 8 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

demo/src/main/java/com/vaadin/components/gwt/polymer/client/sampler/paper/RadioGroupSample.ui.xml, line 52 [r1] (raw file): This is not correct. The checked item is already specified in radio group.

Comments from the review on Reviewable.io

manolo commented 9 years ago

Review status: 5 of 8 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

demo/src/main/java/com/vaadin/components/gwt/polymer/client/sampler/paper/RadioGroupSample.ui.xml, line 52 [r1] (raw file): I see, will remove this

Comments from the review on Reviewable.io

cwayfinder commented 9 years ago

Review status: 5 of 8 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful.

demo/src/main/java/com/vaadin/components/gwt/polymer/client/sampler/paper/FabSample.ui.xml, line 67 [r1] (raw file): We lose tabindexes. Should we add set/getTabIndex() to PolymerWidget.java?

Comments from the review on Reviewable.io

manolo commented 9 years ago

Review status: 5 of 8 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

demo/src/main/java/com/vaadin/components/gwt/polymer/client/sampler/paper/FabSample.ui.xml, line 67 [r1] (raw file): Yes we should

Comments from the review on Reviewable.io