search

manolo / gwt-polymer-elements

Polymer Web Components for GWT. A collection of Material Design widgets for desktop and mobile.
Apache License 2.0
155 stars 49 forks source link

Convert elements to widgets #29

Closed cwayfinder closed 9 years ago

cwayfinder commented 9 years ago

Review on Reviewable

Saulis commented 9 years ago

Review status: 0 of 23 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

demo/src/main/java/com/vaadin/components/gwt/polymer/client/sampler/paper/DialogSample.ui.xml, line 70 [r1] (raw file): markerAttributes could be named better, i.e. addAttributes or addCustomAttributes. See https://github.com/vaadin/gwt-api-generator/pull/32

Comments from the review on Reviewable.io

manolo commented 9 years ago

Reviewed 19 of 23 files at r1, 4 of 4 files at r3. Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

Comments from the review on Reviewable.io