Closed manolo closed 9 years ago
Looks good, I'll test it out manually after vaadin/gwt-api-generator#33 has been merged.
Review status: 0 of 4 files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from the review on Reviewable.io
Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.
package.json, line 4 [r2] (raw file):
I would remove release
property.
package.json, line 9 [r2] (raw file): Remove #mcm_pom before merging.
package.json, line 14 [r2] (raw file):
I would use organization
here instead of org
to reflect the usage.
Comments from the review on Reviewable.io
Reviewed 1 of 4 files at r1, 4 of 4 files at r4. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from the review on Reviewable.io