search

manolo / gwt-polymer-elements

Polymer Web Components for GWT. A collection of Material Design widgets for desktop and mobile.
Apache License 2.0
155 stars 49 forks source link

Update Polymer to v1.2.1. Add sample for vaadin-grid #70

Closed manolo closed 8 years ago

manolo commented 8 years ago

Review on Reviewable

connects to vaadin/components-team-tasks#34 connects to #69

Saulis commented 8 years ago

Review status: 0 of 8 files reviewed at latest revision, 1 unresolved discussion.

package.json, line 8 [r1] (raw file): We should have a version number for the gwt-api-generator here.

Comments from the review on Reviewable.io

manolo commented 8 years ago

Review status: 0 of 8 files reviewed at latest revision, 1 unresolved discussion.

package.json, line 8 [r1] (raw file): Done.

Comments from the review on Reviewable.io

Saulis commented 8 years ago

Review status: 0 of 19 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

demo/pom.xml, line 72 [r3] (raw file): Had to fix the version here, 2.7.0 works nicely. 2.8.0-SNAPSHOT isn't available. 2.6.1 fails.

package.json, line 11 [r3] (raw file): Hard coded to fa92309 which is the first revision that contains the behaviors in vaadin-grid-doc.html

Comments from the review on Reviewable.io

Saulis commented 8 years ago

Rebased onto origin/master

Review status: 0 of 17 files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io