Closed manolo closed 8 years ago
I need the latest JsInterop syntax. When will a gwt-polymer-elements release with the latest JsInterop syntax available?
Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion.
package.json, line 11 [r1] (raw file): Does this branch of vaadin-grid exist publicly?
Comments from the review on Reviewable.io
Edit: JsInterop reference was causing failure in Maven build with GWT 2.8.0-SNAPSHOT on January 6. The build now works fine again, but indicates that the SNAPSHOT is still in an unstable phase.
Likely related to gwtproject/gwt#9235
Review status: 0 of 12 files reviewed at latest revision, 2 unresolved discussions.
package.json, line 11 [r1] (raw file): it was needed when I did the PR, the branch is merged so changed to #master
Comments from the review on Reviewable.io
Review status: 0 of 12 files reviewed at latest revision, 2 unresolved discussions.
package.json, line 11 [r1] (raw file): It is in master
Comments from the review on Reviewable.io
@frami : use gwt-polymer-elements-1.2.3.0-SNAPSHOT and gwt-2.8.0-SNAPSHOT in your project and should work
Review status: 0 of 12 files reviewed at latest revision, 2 unresolved discussions.
_Comments from the review on Reviewable.io_
Thank you, the snapshot version works for me.
LGTM now that changes discussed in Skype are resolved. :+1:
Reviewed 2 of 5 files at r1, 7 of 10 files at r2, 8 of 13 files at r3, 5 of 5 files at r4. Review status: all files reviewed at latest revision, 1 unresolved discussion.
Comments from the review on Reviewable.io
_package.json, line 8 [r6] (raw file):_ This JS_RC branch is going to be deleted once https://github.com/vaadin/gwt-api-generator/pull/54 gets merged
Comments from the review on Reviewable.io
Fixes #83 Fixes #84 Fixes #86 Fixes #81 Fixes #79 Fixes #49 Fixes #48
Reviewed 2 of 2 files at r5, 1 of 1 files at r6, 3 of 3 files at r7. Review status: 22 of 23 files reviewed at latest revision, 2 unresolved discussions.
Comments from the review on Reviewable.io
Connected with vaadin/gwt-api-generator#54 Fixes #66