search

manub / scalatest-embedded-kafka

A library that provides an in-memory Kafka instance to run your tests against.
MIT License
295 stars 87 forks source link

Remove log4j and slf4j #124

Closed francescopellegrini closed 6 years ago

francescopellegrini commented 6 years ago

Completes the work started in the obsolete remove_log4j branch.

manub commented 6 years ago

Are you sure this doesn't pull log4j as a transitive dependency from Kafka to whoever uses this library?

francescopellegrini commented 6 years ago

It surely does. This raises a question: why bother excluding slf4j-log4j12 in the first place? I'm closing this PR and opening another one to better explain what I mean.

francescopellegrini commented 6 years ago

See #127