search

marceloprates / prettymaps

A small set of Python functions to draw pretty maps from OpenStreetMap data. Based on osmnx, matplotlib and shapely libraries.
GNU Affero General Public License v3.0
11.12k stars 522 forks source link

build: Add MANIFEST.in with prune strategy #68

Closed matthewfeickert closed 3 years ago

matthewfeickert commented 3 years ago 
* Use `prune **` to remove all files from the sdist
    - c.f. https://packaging.python.org/guides/using-manifest-in/#manifest-in-commands
    - "Setuptools also has undocumented support for ** matching zero or
       more characters including forward slash, backslash, and colon."
* Manually include all "default" files for a sdist in MANIFEST.in
    - c.f. https://packaging.python.org/guides/using-manifest-in/#how-files-are-included-in-an-sdist
* Include requirements.txt as not using declartive spec for setup
matthewfeickert commented 3 years ago

@marceloprates this is ready for review. If you have questions on why things are setup this way I'm happy to elaborate and if you would like to see this MANIFEST.in being used to build a sdist and a wheel in CI (which is Issue #67) I have a branch on my fork with this working. :+1:

cc @thewchan as they opened up Issue #65 and so may be curious to look at this as well.

thewchan commented 3 years ago

Thanks so much; once this is pushed to a new release it would really help with my attempt to get this package onto Conda Forge.

matthewfeickert commented 3 years ago

once this is pushed to a new release it would really help with my attempt to get this package onto Conda Forge.

Issue #67 will help with that as well. I have a PR ready to go once I'm out of my current meeting.