search

marcotcr / checklist

Beyond Accuracy: Behavioral Testing of NLP models with CheckList
MIT License
2.01k stars 204 forks source link

Minor fix to Wordnet text generation score #99

Closed CristianManta closed 3 years ago

CristianManta commented 3 years ago

Hi,

When you fixed a bug with Wordnet in commit bf51a392daea25a8f920cbf1c8474f76bcf41e0d, it removed the sensitivity to the threshold parameter from editor.synonyms. I found that it is caused by this line. I think you rather meant

score = score[0][-1]

Sorry for noticing it so late (I opened the original issue that prompted you to include the fix), I was also fooled by reading your diff, only to later notice that something was fishy with the quality of the synonyms suggested :)

Thanks Cristian

marcotcr commented 3 years ago

Oh wow, yes, that was a blunder. Thanks for catching it! Fixed in a7b39ac