search

marianokit / magento-w2p

Automatically exported from code.google.com/p/magento-w2p
0 stars 0 forks source link

Full size fancybox for large previews #251

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
We need to show full size previews in the fancybox.
The default size should remain as it is now. It's a good compromise.

Add a button next to X at the top right corner (design?) to expand it to the 
full size of the preview. The button changes to "collapse" (design?). 

The button only appears if the preview is larger than what is shown.

Some items such as letterheads have small fonts on a large sheet. Can't be read.

Printers can control the default preview size per template. Let them do it.

Features: normal size preview, real size, big or small, all under control
Help: how to control default preview size. We probably already have something 
along these lines.

Original issue reported on code.google.com by zetapri...@gmail.com on 8 Jul 2010 at 9:17

GoogleCodeExporter commented 8 years ago 
We need to decide between these 2 versions. Mockups attached.

Original comment by agur...@gmail.com on 13 Jul 2010 at 12:31

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by zetapri...@gmail.com on 20 Jul 2010 at 10:24

GoogleCodeExporter commented 8 years ago

Original comment by zetapri...@gmail.com on 18 Aug 2010 at 10:50

GoogleCodeExporter commented 8 years ago 
Let's use D2

Original comment by zetapri...@gmail.com on 20 Aug 2010 at 12:44

GoogleCodeExporter commented 8 years ago

Original comment by trilobit.alex@gmail.com on 23 Aug 2010 at 6:29

GoogleCodeExporter commented 8 years ago

Original comment by agur...@gmail.com on 23 Aug 2010 at 8:51

Attachments:

GoogleCodeExporter commented 8 years ago 
No commit by alex. Need to start over.

Original comment by zetapri...@gmail.com on 10 Oct 2010 at 7:14

GoogleCodeExporter commented 8 years ago 
Do we have a product to test it on?
Can someone post a link here?

Original comment by zetapri...@gmail.com on 2 Dec 2010 at 9:48

GoogleCodeExporter commented 8 years ago 
All yard sign templates are rather large. There's usually e few on each 
instance that has the w2p ext installed:
http://ec2-174-129-95-130.compute-1.amazonaws.com/mageimage/index.php/category-0
2/4xpage-sign.html
http://ec2-174-129-95-130.compute-1.amazonaws.com/magento/index.php/approval/fsb
o-combo-package-yard-sign-left-and-right-arrow-signs.html

Original comment by agur...@gmail.com on 2 Dec 2010 at 10:15

GoogleCodeExporter commented 8 years ago 
What are the matching pages on ZP site for comparison?

Original comment by zetapri...@gmail.com on 2 Dec 2010 at 7:19

GoogleCodeExporter commented 8 years ago 
This is the link to the template on w2p portal:
http://cname.zetaprints.com/?page=template;TemplateID=11588DCB-38B2-4688-A625-84
8433259418

Original comment by agur...@gmail.com on 2 Dec 2010 at 7:22

GoogleCodeExporter commented 8 years ago 
I am kind of lost with this task. 
Both products expand fancy box to linked image size - 600x600px. 
Are there larger preview images? 
How to tell which are/should be larger?
Fancy box basically shows image that it is already loaded in the page - so 
should we change server code to fetch large images?

Original comment by jamb...@gmail.com on 3 Dec 2010 at 12:03

GoogleCodeExporter commented 8 years ago 
Yes, you are right tha original size of image is 600x600 px.
But you can make you browser window smaller thus you can simulate an image that 
bigger then you browser' window size.

> Fancy box basically shows image that it is already loaded in the page
An image is shown in its original size, so no need to change some server code 
:-)

Original comment by Anatoly....@gmail.com on 3 Dec 2010 at 6:22

GoogleCodeExporter commented 8 years ago 
I got that after talking with Max, my error. I am almost done, will commit the 
change later today.

Original comment by jamb...@gmail.com on 6 Dec 2010 at 8:21

GoogleCodeExporter commented 8 years ago 
Please, don't forget to update your branch to the latest trunk and then commit 
your changes on top of it.

Original comment by Anatoly....@gmail.com on 6 Dec 2010 at 8:34

GoogleCodeExporter commented 8 years ago 
One more thing, final variant that is chosen here - I need just the icons in 
png/gif variant. I can't really slice them without photoshop.
Also I notice that all variants are using double symmetrical icon. Which will 
be a small problem. When image is shown full size and there is no need to 
expand - then the icon will not respond to interactions - which is always 
confusing for user.
I have opted for hiding max/restore icon when it is not needed but having this 
symmetrical view - this will not look too good either.
How to go about that issue?

Original comment by jamb...@gmail.com on 6 Dec 2010 at 8:37

GoogleCodeExporter commented 8 years ago 
I added the icons to the current fancybox sprite. Is this ok?

About the issue you mentioned... can we have a single X icon showing up when 
there's no larger preview? That way the symmetrical (expand/collapse and close) 
icon will only show when there is actually a larger preview available.

Original comment by agur...@gmail.com on 6 Dec 2010 at 9:09

Attachments:

GoogleCodeExporter commented 8 years ago 
Probably we can. As long as you are happy. I just wanted to bring up the 
problem early.
As for the sprite - it is fine, just that IE6 uses separate icon, if we don't 
care about that then we're fine

Original comment by jamb...@gmail.com on 6 Dec 2010 at 9:25

GoogleCodeExporter commented 8 years ago 
Feature added to branch.
http://code.google.com/p/magento-w2p/source/detail?r=1211
I have internet problem and can't connect to aws instances - my main IP is off, 
so I couldn't apply the change to M. installation. As soon as IP is back online 
I will make a demo.
If anyone else wants to do it, just grab modified files from the revision and 
place them in corresponding folders of M. install with web 2 print enabled.
At present resizing is enabled for product page previews. This is until all 
bugs are squashed.
Enabling it is quite easy, add resizing.js, resizing.css to respected page, and 
add a function to fancybox.onComplete:

'onComplete':function () {
      addResizeOption(this);
}

Original comment by jamb...@gmail.com on 6 Dec 2010 at 3:06

GoogleCodeExporter commented 8 years ago 
http://code.google.com/p/magento-w2p/source/detail?r=1211 - here is my code 
review.

Original comment by Anatoly....@gmail.com on 6 Dec 2010 at 4:31

GoogleCodeExporter commented 8 years ago 
Added demo.
http://ec2-174-129-95-130.compute-1.amazonaws.com/mageimage/index.php/category-0
2/4xpage-sign.html
Until bugs are cleared only product page preview images have the feature added 
to them.

Original comment by jamb...@gmail.com on 6 Dec 2010 at 6:41

GoogleCodeExporter commented 8 years ago 
I see incorrect background positions and width
Change them to:

#fancybox-close: background-position: -67px -200px;
#fancybox-resize a: width: 28px;

Original comment by Anatoly....@gmail.com on 6 Dec 2010 at 6:58

GoogleCodeExporter commented 8 years ago 
Try to use onStart callback instead onComplete

Original comment by Anatoly....@gmail.com on 6 Dec 2010 at 7:00

GoogleCodeExporter commented 8 years ago 
Didn't see any change whatsoever. Use the link from comment 21.
What am I missing?

Original comment by zetapri...@gmail.com on 7 Dec 2010 at 10:29

GoogleCodeExporter commented 8 years ago

Original comment by zetapri...@gmail.com on 7 Dec 2010 at 10:30

GoogleCodeExporter commented 8 years ago 
Atanas used mageimage for testing new w2p release :-( So code uploaded by Petar 
was replaced.

Original comment by Anatoly....@gmail.com on 7 Dec 2010 at 11:33

GoogleCodeExporter commented 8 years ago 
@24, I have re added demo code.
@22, fancybox-close background-position is exactly in the middle. White line in 
the middle is 2px wide so ideally it should be even between the two buttons. I 
think that resize and close links should be same width, currently close is 30px 
wide and tall. Biggest problem I see is IE, in IE fancybox is not using the big 
sprite to show close icon background, and that is not working good. We have 2 
options, one is to override IE styles in our css and have it use the sprite and 
the other is to have separate icons.
Problem I see with option one is that IE does not behave the same between 6, 7 
and 8 and probably that is why it has separate styling in first place.
Problem with second option is - more image requests if we have more icons.
Have to pick the lesser problem and use it. I am all for separate icons.

Original comment by jamb...@gmail.com on 7 Dec 2010 at 12:49

GoogleCodeExporter commented 8 years ago 
@23
Is on start called when image dimensions are known? I think it is called before 
content is loaded.

Original comment by jamb...@gmail.com on 7 Dec 2010 at 12:51

GoogleCodeExporter commented 8 years ago 
There's also a problem with the "X" half part of the button. It disappears in 
all browsers after it is clicked.

Original comment by agur...@gmail.com on 7 Dec 2010 at 1:26

GoogleCodeExporter commented 8 years ago 
This is because it gets closed. This is fancybox feature, hide close link 
immediately and animate back fancybox. Not sure how to prevent this

Original comment by jamb...@gmail.com on 7 Dec 2010 at 1:37

GoogleCodeExporter commented 8 years ago 
@28
I don't know, just check it.

Original comment by Anatoly....@gmail.com on 7 Dec 2010 at 1:38

GoogleCodeExporter commented 8 years ago 
Well I do know, not loaded

Original comment by jamb...@gmail.com on 7 Dec 2010 at 2:04

GoogleCodeExporter commented 8 years ago 
@29 I can't make close link to close slower but can close resizer with it. Test 
it now.

Original comment by jamb...@gmail.com on 7 Dec 2010 at 2:17

GoogleCodeExporter commented 8 years ago 
@33 Yep, this seems like a good compromise to me. Both sides of the button 
disappear now and it doesn't look broken like it did before.

Original comment by agur...@gmail.com on 7 Dec 2010 at 2:25

GoogleCodeExporter commented 8 years ago 
Seems like w2p has been reinstalled again. Will install w2p on magedev for 
demo. Might take some time to import w2p products.

Original comment by jamb...@gmail.com on 7 Dec 2010 at 2:39

GoogleCodeExporter commented 8 years ago 
Sorry Petar. I did it for testing this one:
http://code.google.com/p/magento-w2p/issues/detail?id=227
Thought I had a green flag.
Use the CNAME poartl for products. It has a small amount of products but enough 
for all different testing scenarios. Should import within seconds. Let me know 
if you don't have API and stuff for it and I'll set it up for you.

Original comment by agur...@gmail.com on 7 Dec 2010 at 2:45

GoogleCodeExporter commented 8 years ago 
I added the products from an account Max has given me some time ago. Activated 
only four of those on magedev. Here is one:
http://ec2-174-129-95-130.compute-1.amazonaws.com/magedev/index.php/test/dvd-lab
el-06.html

Original comment by jamb...@gmail.com on 7 Dec 2010 at 5:10

GoogleCodeExporter commented 8 years ago 
Looks alright. Didn't test properly, though.

Original comment by zetapri...@gmail.com on 7 Dec 2010 at 7:04

GoogleCodeExporter commented 8 years ago

Original comment by zetapri...@gmail.com on 14 Dec 2010 at 9:45

GoogleCodeExporter commented 8 years ago 
Petar, do you have all code relative to the issue into your branch?

Original comment by Anatoly....@gmail.com on 10 Jan 2011 at 1:30

GoogleCodeExporter commented 8 years ago 
Is this what you need?
http://code.google.com/p/magento-w2p/source/browse/branches/w2p_petar/skin/front
end/default/zptheme/js/resizing.js?r=1294

Original comment by jamb...@gmail.com on 10 Jan 2011 at 3:12

GoogleCodeExporter commented 8 years ago 
Yes. Is it latest code?

Original comment by Anatoly....@gmail.com on 10 Jan 2011 at 4:13

GoogleCodeExporter commented 8 years ago 
I think so. Is there a problem with it?

Original comment by jamb...@gmail.com on 10 Jan 2011 at 4:21

GoogleCodeExporter commented 8 years ago 
I will merge it and will release for testing after.

Original comment by Anatoly....@gmail.com on 10 Jan 2011 at 5:55

GoogleCodeExporter commented 8 years ago

Original comment by zetapri...@gmail.com on 11 Jan 2011 at 4:55

GoogleCodeExporter commented 8 years ago

Original comment by Anatoly....@gmail.com on 11 Jan 2011 at 1:02

GoogleCodeExporter commented 8 years ago

Original comment by zetapri...@gmail.com on 13 Jan 2011 at 3:17

GoogleCodeExporter commented 8 years ago

Original comment by zetapri...@gmail.com on 13 Jan 2011 at 4:57

GoogleCodeExporter commented 8 years ago 
Test it with 1.8.4.0alpha19 release on magento (dev)

Original comment by Anatoly....@gmail.com on 17 Jan 2011 at 7:50

GoogleCodeExporter commented 8 years ago 
Doesn't look like this release includes the resizer option. The corner button 
is a simple X no matter how many times I refresh the window:
http://ec2-174-129-95-130.compute-1.amazonaws.com/magento/index.php/approval/fsb
o-square-sign-02-2-photos-24-x-24.html

Also tried installing v. 1.8.4.0alpha19 release on /magedev/. Same.

Original comment by agur...@gmail.com on 19 Jan 2011 at 4:49