search

mark2devel / mark2

Minecraft Multi Server Wrapper Written in Python with Twisted; Pull Requests HIGHLY Encouraged, Collaborators Needed Discord: https://discord.gg/zymJygHNpv
Other
208 stars 44 forks source link

Add ~backup support for 1.13 save-on save-off message #104

Closed Combustible closed 5 years ago

Combustible commented 6 years ago

Yes, they really did change the freaking save-off message again...

Tested that this works on 1.13.1 and also still works on 1.12.2

Combustible commented 6 years ago

Occurs to me I should have posted why this change is needed:

When you say ~backup, mark2 sends the 'save-off' command to the minecraft server. It then waits for the message from the server saying that world saving has been disabled.

However, 1.13 changes that message - so mark2 never sees it. So mark2 thinks a "backup is in progress" forever - you can no longer ~stop or even ~kill the server (gives an error about backup in progress)

Without this change you have to manually go in and kill either the server or mark2 to get it to exit.