search

mark2devel / mark2

Minecraft Multi Server Wrapper Written in Python with Twisted; Pull Requests HIGHLY Encouraged, Collaborators Needed Discord: https://discord.gg/zymJygHNpv
Other
208 stars 44 forks source link

Ported mark2 to Python 3 #130

Closed Column01 closed 3 years ago

Column01 commented 3 years ago

After some painstaking work and well over 12-16 hours of debugging, I have (finally) completed a port of mark2 to python 3! Please note: This includes changes to the readme I submitted in my last PR: #127 which will be closed as of posting.

I tested as much of the functionality as I could (it even passes the self-tests apart from the .parse_time ones that I'm pretty sure are just due to other changes in the code base over the years).

What I could not test is the integrations (IRC, Mumble etc.) as I don't have the infrastructure set up to test that.

I am willing and able to maintain mark2 post update and fix any bugs this port reveals. I do recommend making a new branch on the repository for this port as I would consider this a test more than a polished port due to the above lack of testing for the integrations.

Column01 commented 3 years ago

Note: The install guide will need to be updated. I can update the ubuntu one with certainty but others will need to pitch in for the other distros to confirm the process works

Column01 commented 3 years ago

@gsand any chance you have some other way I could contact you to discuss this? Would be nice for this to be considered

gsand commented 3 years ago

Hi, I’ve added you as a collaborator. Mark2 needed collaborators. Thank you for updating to python3.