search

mark2devel / mark2

Minecraft Multi Server Wrapper Written in Python with Twisted; Pull Requests HIGHLY Encouraged, Collaborators Needed Discord: https://discord.gg/zymJygHNpv
Other
205 stars 44 forks source link

Discord Alert Plugin and replacement of deprecated methods #133

Closed Column01 closed 2 years ago

Column01 commented 2 years ago

Added a plugin that will send alerts to a discord webhook

Replaced deprecated twisted getPage calls with treq.get ones.

Note: treq.get returns a response object so all calls that were made with getPage also have an additional step to get the text value they needed for parsing. If any were missed, this could break other plugins using this method. I have tried to find them all but would like this to be reviewed by @edk0 before pulling into master as he knows more about the callbacks that are present from these calls than I do.

Column01 commented 2 years ago

Hmm, seems response.text() is deferred and not a string like I thought it was. Will have to test more

Column01 commented 2 years ago

Working on fixing stuff so the review can wait

Column01 commented 2 years ago

AFAIK, it should be all good for review now @edk0

I confirmed the jar system works again. mark2 jar-list and mark2 jar-get -> with vanilla jars only. there is a Jenkins jar provider in there, but to my knowledge, it probably wouldn't work anymore

Column01 commented 2 years ago

I tested as many of the changes/features as I can and I will be merging them into master.