search

mark2devel / mark2

Minecraft Multi Server Wrapper Written in Python with Twisted; Pull Requests HIGHLY Encouraged, Collaborators Needed Discord: https://discord.gg/zymJygHNpv
Other
208 stars 44 forks source link

Comment out optional alert config to avoid possible error on shutdown #165

Closed synrg closed 2 years ago

synrg commented 2 years ago

I considered what you said about alert not being needed and agree, it's not strictly necessary. Also, since it requires an optional plugin, if the user didn't install it and they use the sample config, it will trigger an error each time velocity is shutdown via mark2 when it attempts to send the alert with the non-existent command. Therefore, I have commented it out. It's up to the user to uncomment it if they also install the plugin.

Column01 commented 2 years ago

Looks like the commit history is a bit odd including the merged PR from before. Can you try making a new branch from the mark2 master and adding the change again in a new PR? If I merge this the commit history will get messy lol. In the future, you want to fastforward your fork before making changes (it appears on the github page of your fork near where the "Contribute" button is)

Column01 commented 2 years ago

Screenshot_20211218-094914_Brave

synrg commented 2 years ago

Yeah. You committed it so fast after I submitted ... I was literally in the middle of making the change as you accepted the original PR! oops. ok, i'll go back and tidy it up. no problem.