search

martasmith / AndroidToDo

A simple Android App that lets the user add, modify, and delete items from a todo list.
1 stars 0 forks source link

TodoApp Initial submission - please review #1

Open martasmith opened 10 years ago

martasmith commented 10 years ago

My todo app is complete, with all the required functionality implemented, including the edit feature. I noticed a slight issue when making my LICEcap walkthrough that my last modification or addition doesn't get saved for some reason. I need to track this down if it is an issue with my code, or some delay is happening in eclipse, as my eclipse install has been having some problems. I have a question about the final submit date. Is it tomorrow by midnight, or how much time do I have to look into this issue and possibly add an extra feature or two? @nesquena @thecodepath

nesquena commented 10 years ago

Hi Marta, yes setup can be one of the most time consuming parts as there are a lot of ways eclipse setup can be wonky. Final submission of working todo app is required by tomorrow at midnight. Extensions can be submitted essentially anytime after that and I accept people on a rolling basis as they complete at least 2 substantial extensions until the classes are filled up. See if you can fix that bug before our call.

Overall, project looks good! This was intended in part to give you an introduction to the general rhythm of this course. The course is entirely project based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer to learn all practical Android development and best practices as quickly as possible. We also do a code review for each submitted project.

The next step is to continue working on extensions to your todo app and to schedule a short 5-10 minute phone conversation here. Navigate to August 29th and dates onward from there and choose a 15-minute slot. Let us know if none of those times work.

Once you select a slot, can you make sure to include best number to reach you at? Look forward to chatting soon!

martasmith commented 10 years ago

Nathan,

I will definitely try to resolve this issue by our phone call this Friday. I accepted your calendar invite. I'm looking forward to chatting with you as well!

-Marta

On Wed, Aug 27, 2014 at 10:26 PM, Nathan Esquenazi <notifications@github.com

wrote:

Hi Marta, yes setup can be one of the most time consuming parts as there are a lot of ways eclipse setup can be wonky. Final submission of working todo app is required by tomorrow at midnight. Extensions can be submitted essentially anytime after that and I accept people on a rolling basis as they complete at least 2 substantial extensions until the classes are filled up. See if you can fix that bug before our call.

Overall, project looks good! This was intended in part to give you an introduction to the general rhythm of this course. The course is entirely project based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer to learn all practical Android development and best practices as quickly as possible. We also do a code review for each submitted project.

The next step is to continue working on extensions to your todo app https://gist.github.com/nesquena/843228e83fdc4f5ddc4e#5-extending-your-todo and to schedule a short 5-10 minute phone conversation here https://www.google.com/calendar/selfsched?sstoken=UURvT01vbzBza1pnfGRlZmF1bHR8NzVjYzBkN2EyZTRiOGRmYjZlZjhmMjA2N2IyMGMwYWU. Navigate to August 29th and dates onward from there https://www.google.com/calendar/selfsched?sstoken=UURvT01vbzBza1pnfGRlZmF1bHR8NzVjYzBkN2EyZTRiOGRmYjZlZjhmMjA2N2IyMGMwYWU and choose a 15-minute slot. Let us know if none of those times work.

Once you select a slot, can you make sure to include best number to reach you at? Look forward to chatting soon!

— Reply to this email directly or view it on GitHub https://github.com/martasmith/AndroidToDo/issues/1#issuecomment-53675111 .

nesquena commented 10 years ago

I've added an additional troubleshooting section to the todo app gist. You may find that helpful if you have certain setup issues.

martasmith commented 10 years ago

Nathan,

Those guidelines definitely helped me! I had a problem where if I did not close and reopen the emulator, the emulator did not update, and I got a warning in red: "Activity not started, it's current task has been brought to front." This is why I assumed that I had to launch the emulator each time. So I carefully re-watched the video posted about the TodoApp, and I noticed that in order to get a refreshed emulator view without relaunching, a change of some sort needs to take place, like adding a space somewhere at an end of a line (minute 32:27 in video). This info might help others if you make a mention of this as well in the last bullet point of your new troubleshooting section.

And the good news is, that I no longer have issue with persistence and other strange random issues if I don't relaunch the emulator each time I want to run the app. So would you like me to make a new LICEcap animation and upload it to the README that demonstrates this? Please advise on how I should proceed.

-Marta

On Wed, Aug 27, 2014 at 11:10 PM, Nathan Esquenazi <notifications@github.com

wrote:

I've added an additional troubleshooting section https://gist.github.com/nesquena/843228e83fdc4f5ddc4e#file-troubleshooting-md to the todo app gist. You may find that helpful if you have certain setup issues.

— Reply to this email directly or view it on GitHub https://github.com/martasmith/AndroidToDo/issues/1#issuecomment-53677397 .

nesquena commented 10 years ago

Great, I added a note about that to the troubleshooting guide (let me know if the new item would have helped you avoid that issue). Glad to hear the other issues have disappeared now as well.

No need to re-record yet. I'd start working on extensions and linked above and reply back here and re-record each time you add a new feature so I can review.

martasmith commented 10 years ago

I reviewed your new note. So if I want to re-run my app without making any changes (such as in the case of testing persistence) does the emulator refresh even if I don't make a modification to one of the files? Because what drove me to relaunch the emulator is that I did not get the desired result by just simply running the app. (I got the red warning I spoke of above). So for me, the key information is that if you want your app to refresh without relaunching the emulator, you need to make a change to one of the files, save it, and run the app again.

nesquena commented 10 years ago

When you hit run without making a modification, the app doesn't refresh it just brings the existing app as it is to the foreground. I adjusted the note to hopefully clarify the fact that to reload the app you need to make a change to a file.

martasmith commented 10 years ago

That really clears things up, thanks! Your new bullet point would have helped me avoid this issue for sure!

martasmith commented 10 years ago

Also, in your "Avoid installing API 4.4W" bullet point, you mention to only install Android L and API 19. However, if I remember right, Android L requires Java 7, so if we implement the workaround for the ADT to use Java 6, the app won't compile if Android L is used. So until we have to use this workaround, API 19 should be specified when rendering layout. That also took me a bit of research to figure out.

nesquena commented 10 years ago

I've added that to the 2nd note, thanks.

martasmith commented 10 years ago

My new feature updates are on github! They are the following:

The new features are documented in the updated ReadMe file, demonstrated with a new LICEcap animation.

I could further improve the code by:

@nesquena @thecodepath

nesquena commented 10 years ago

You definitely did a nice job here Marta, reviewed your changes carefully and great to see you completed several of the key optionals! I've sent you a followup via email, hope you can participate in the bootcamp but unfortunately there are only spots left in the SF one at this point.

martasmith commented 10 years ago

I live in San Mateo, so the San Francisco Monday / Wednesday option works just as well for me! I only had a slight preference, because I had to make a choice between the two locations. I do realize what an amazing opportunity this is, a possible life changer for me. I am very grateful to be considered in the first place, then accepted into the program! I am really looking forward to next week! :)

nesquena commented 10 years ago

Of course, glad to have you participate!.Glad Bianca referred you to our program, hope you enjoy it and we are able to help you work towards your goals. I think you'll have a lot of fun or at the very least learn a lot about what it takes to be a professional Android developer!