search

martiensk / vuex-jsdoc

A JSDoc plugin for documenting Vuex modules.
9 stars 2 forks source link

Removed the column header if the default value was not present. #9

Closed whoacowboy closed 2 years ago

whoacowboy commented 2 years ago

simplified

defaultvalue: tag.value.defaultvalue === undefined ? undefined : tag.value.defaultvalue

to

defaultvalue: tag.value.defaultvalue

Added a check for columnInfo.showDefaultValue in tabler.js to prevent an empty description column.

martiensk commented 2 years ago

Looks good. Do you mind removing commented code?

whoacowboy commented 2 years ago

@martiensk NP.

whoacowboy commented 2 years ago

This should resolve issues #3 and #4. I am thinking of adding support for action dispatch would you be up for incorporating that or should I start up a new project?

martiensk commented 2 years ago

I have officially stopped supporting this plugin due to IRL stuff but happy to incorporate any additional features you want to add. Also happy for you to fork if you'd rather do it that way, up to you.

whoacowboy commented 2 years ago

@martiensk I get the IRL stuff. Let me see how far I go with it for my own needs. If I start to rely on it too heavily I may take it on just so I can support it. Thanks!