search

martin-helmich / phpunit-psr7-assert

PHPUnit assertions for PSR-7 messages
MIT License
24 stars 4 forks source link

Update helmich/phpunit-json-assert #22

Closed martinssipenko closed 3 years ago

martinssipenko commented 3 years ago

@martin-helmich dependabot has not kicked in yet so I did a manual update. Could I ask you to take a look at this and do a release after merge?

martin-helmich commented 3 years ago

:+1: Thanks for the PR.

On a side note, I found out why dependabot decided to remain inactive -- it seems like depedabot is much stricter regarding updates than Composer itself. Apparently, this libraries PHP requirement is ^7.1, whereas helmich/phpunit-json-assert in 3.4 has ^7.2.

De facto, this update raises the PHP requirement of this library from ^7.1 to ^7.2 -- which I can live with, since 7.1 has been EOL for over a year anyway (as is 7.2, as of recently).

martinssipenko commented 3 years ago

@martin-helmich shall I make a required PHP version bump too?

martin-helmich commented 3 years ago

shall I make a required PHP version bump too?

Just had the same thought. Added a suggestion. :)

martin-helmich commented 3 years ago

:+1: Merged. Release is also published.

martinssipenko commented 3 years ago

👍 Merged. Release is also published.

Thank you very much!