Open martinkarugaba opened 6 months ago
Hi Team,
Good job so far, indeed you have spent time on this project! There are some issues that you still need to work on to go to the next project but you are almost there!
Check the comments under the review.
[ ] I can see you have your description except the last one which I encourage you to add but the number of points is yet to be added, the point should serve as the expected number of time the student should work on it, kindly add it for each task.
[ ] I noticed that some tasks are not shown at all in your project division such as recipe list, I will encourage you to use the pointed ones in the image below as the descriptive heading of each card and use the tasks under them as the detailed description so that it would entail all tasks.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @martinkarugaba ππΌππΌππΌ,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! π
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
@martinkarugaba @mryeminthu