search

martinproks / cosmeticthread3d

FreeCAD tool - cosmetic thread for 3D geometry - experimental
GNU Lesser General Public License v2.1
4 stars 0 forks source link

Threads ignore removal of material #9

Open pierreporte opened 7 months ago

pierreporte commented 7 months ago

When material is removed from a threaded part, the threads should disappear locally. This should be the case in drawings as well.

More details on the FreeCAD bug tracker in the issue about what cosmetic threads needs to do: https://github.com/FreeCAD/FreeCAD/issues/5567#issuecomment-1805915809

image

image

image

image

martinproks commented 7 months ago

At this moment, thread geometry does not check true geometry like this. Not yet. At this moment (2024/03) it is basic exploration of the way, how to do cosmetic threads.

Another known issues but the same base problem - cosmetic threads 3D does not check true geometry of hole / rod they are attached to.

known_issues_of_ct3d

pierreporte commented 5 months ago

The new PartDesign threads don’t show the cylinder when the thread has material removed but the lack of an helix (issue #34) and standard representation in drawings (#33) keeps me from checking if the thread is still floating in empty space or not.

martinproks commented 5 months ago

Hi,

The new PartDesign threads don’t show the cylinder when the thread has material removed but the lack of an helix (issue #34) and standard representation in drawings (#33) keeps me from checking if the thread is still floating in empty space or not.

I think in PartDesign it is OK. See attached drawing. PD_ct3d_groowe_and_pin

pierreporte commented 5 months ago

With your last updates, I learned that PD0 actually removes material already to it’s no surprise that the drawing looks correct. You already know that it’s not a perfect solution since it brings a whole lot of new problems.

martinproks commented 5 months ago

Yeas I konw. I don't like the solution with remove material. I want to make it based on shells or may be just curves - PartDesign::DraftObjects. But for now this is first try to make PartDesign version. All the things around are more time and brain consuming than the core feature code itself for me. Other solution PD1 and may-be more will follow.

pierreporte commented 5 months ago

I get this result when adding a chamfer to external PD threads. Chamfers on internal PD threads work.

image