match4everyone / match4healthcare

Helping hospitals find qualified medicine students (Hackathon #wirvsvirus). A more flexibel version is currently in development under match4everyone/match4everything,
https://match4healthcare.de
Other
17 stars 10 forks source link

black and flake8 have conflicting rules for blank lines after the docstring #518

Closed Baschdl closed 4 years ago

Baschdl commented 4 years ago

backend/apps/ineedstudent/converters.py:2:1: D205 1 blank line required between summary line and description

@kevihiiin that was your problem

bjrne commented 4 years ago

Can you give an example @Baschdl? I fixed the problem flake8 was mentioning in a following commit.

Baschdl commented 4 years ago

This fix interestingly didn't work for me but it's fine if it's green now

bjrne commented 4 years ago

Then I guess you forgot to stage the changes from black and it seemed that black changed something again, when it only operated on the staged changes thus creating the same unstaged change again, resulting in seemingly the same errors and changes. Will close for now.