search

mate-desktop / libmateweather

Library to access weather information from online services
https://mate-desktop.org
GNU Lesser General Public License v2.1
21 stars 24 forks source link

Fails to build from source with tzdata 2016g #35

Closed jbicha closed 8 years ago

jbicha commented 8 years ago

libmateweather currently fails to build with tzdata 2016g.

GNOME bug: https://bugzilla.gnome.org/show_bug.cgi?id=772253 Patch I submitted to GNOME: https://bug772253.bugzilla-attachments.gnome.org/attachment.cgi?id=336668

Debian patch: https://anonscm.debian.org/git/pkg-mate/libmateweather.git/tree/debian/patches/1001_adapt-to-timezone-namechange-for-Asia-Yangon.patch

monsta commented 8 years ago

Thanks - but can we count on all distros getting this update? We really can't use conditional build here (for old and new name).

monsta commented 8 years ago

@flexiondotorg @sunweaver guys, please check out the updated patch at https://bugzilla.gnome.org/show_bug.cgi?id=772253#c5 - I think it's better as it doesn't break the translations.

jbicha commented 8 years ago

Yes, tzdata should be a mandatory update since it's essential that distros handle daylight savings time and other timezone changes correctly. Ubuntu has applied 2016g to all supported releases already (vivid and wily aren't really supported).

Any distro that chooses to update MATE but not do the tzdata update can simply revert this commit although that's not recommended.

Michael-AU commented 8 years ago

Just wondering when this will be fixed? I have all but 3 (I think it's 3) packages built and installed but this one is required for 2 others (mate-panel has it as a dependency) so things are unusable in MATE-1.16 until this is fixed.

monsta commented 8 years ago

Looks like Ubuntu 14.04 and 16.04 didn't get tzdata update yet. Same in Debian Stable. And libgweather developers still didn't accept the patch upstream. So I'm not sure that we have to accept it in libmateweather right now.

In Debian Testing and Ubuntu 16.10, where tzdata is already updated, libmateweather got patched for it.

jbicha commented 8 years ago

@monsta Ubuntu 14.04 and 16.04 got the tzdata update yesterday

libgweather is a bit undermaintained now. I wouldn't let their delay in making a new release be an excuse for MATE.

monsta commented 8 years ago

libgweather is a bit undermaintained now

Hmm, I have plans for migrating our applets to libgweather for 1.18 release... Our library is maintained worse than gnome's anyway. It seems that moving to libgweather will require less effort than backporting lots of missing stuff.

monsta commented 8 years ago

Ok, patch merged, sorry about the delay.