[Bug] Some icons are not displayed

jassriver commented 3 months ago

Describe the bug

Some icons are not displayed in version 5.5.1

The config folder icon show when I open it, but seeders and other folders are not displayed even when opened

To Reproduce

Steps to reproduce the behavior:

Go to 'extensions'
Click on config in 'Material Icon Theme'
Click on 'Install Another Version'
install 5.5.1 version
See the bug.

Expected behavior

display the icons as always. One way to get around this is to install another version, in this case 5.5.0 works correctly.

Computer information (please complete the following information)

OS edition: Windows 10 PRO
OS build: 19045.4651
VSCode version: 1.91.1

Other information

I've already uninstalled and installed the extension, I've selected the icon theme, I've enabled and re-enabled it, I've restarted the extensions, I've closed and opened vscode, I've restarted my computer and nothing has changed.

PKief commented 3 months ago

@jassriver do you have any customizations enabled for the extension? Like custom icon associations or other settings? If yes, can you please tell us which and try to disable them? You can also run the command "Material Icons: Restore Default Configuration".

If it's not the case, can you post the "material-icons.json" file here? You can find it under this path on your machine: ~/.vscode/extensions/pkief.material-icon-theme-5.5.1/dist/material-icons.json

jassriver commented 3 months ago

I don't have customizations enabled. I ran the command and nothing changed.

This is my material-icons.json material-icons.json mirror pastebin (I couldn't post the content because it exceeds the number of characters that github allows, so I uploaded it here and on pastebin)

karinzaa commented 3 months ago

I have same issue. OS edition: Windows 11 PRO VSCode Version: 1.91.1] and I don't have customizations anything.

jassriver commented 3 months ago

hey @karinzaa if you install another version, like 5.5.0, works correctly or the bug remains?

karinzaa commented 3 months ago

hey @karinzaa if you install another version, like 5.5.0, works correctly or the bug remains?

It works correctly.

PKief commented 3 months ago

I don't have customizations enabled. I ran the command and nothing changed.

This is my material-icons.json material-icons.json mirror pastebin (I couldn't post the content because it exceeds the number of characters that github allows, so I uploaded it here and on pastebin)

Thanks a lot, I compared it with the expected JSON file and it looks 100% the same, which is already a good sign.

As I can't reproduce it right now on my machine, could you please check if there's an error in the developer tools of your vscode and send me a screenshot or error message.

You can toggle the developer tools like this:

In the "console' tab, can you see some error message regarding some SVG files or something which is related to the "PKief.material-icon-theme" extension?

karinzaa commented 3 months ago

@PKief In consol has nothing like .svg error but in network tab is error.

In my case CSS it not work i go to this svg location in my computer it show this when i open it.

I think file is broken to be fix go back to V.5.5.0 and patch work svg file in V.5.5.1.

jassriver commented 3 months ago

@PKief Same for me, there are no errors in the console, the svgs have nothing, when checking my explorer I noticed that a lot of files are empty (0kb)

PKief commented 3 months ago

@karinzaa @jassriver Thanks for that information.

@jassriver Then the files in your extension folder (~/.vscode/extensions/pkief.material-icon-theme-5.5.1/icons) are empty too, right? It's weird because I've checked the extension bundle (the .vsix file) and it contains the icons as expected: https://github.com/material-extensions/vscode-material-icon-theme/releases/download/v5.5.1/material-icon-theme-5.5.1.vsix

PKief commented 3 months ago

You can install that extension directly via file:

Can you please try that out if it helps?

karinzaa commented 3 months ago

@PKief Ok it back to working 👍 Thanks 🙏 But in future it bug it again, I have to repair it myself?

jassriver commented 3 months ago

for me too, works now, thanks.

PKief commented 3 months ago

@PKief Ok it back to working 👍 Thanks 🙏 But in future it bug again, I have to repair it myself?

I need to investigate if there's a process which clears the content of some SVG file. I can't really explain it right now, why it's removing the content of the files and why it seems to work for most of the people. I'll go through it and analyse if I can find some suspicious parts of code which can be responsible for that behavior.

PKief commented 3 months ago

@karinzaa @jassriver I've just published a version 5.6.0 on the VS Code Marketplace. I've changed two settings in the build configuration which have been changed between 5.5.0 and 5.5.1. Maybe it fixes your issue. Feel free to try it out once it's available for you to install it via VS Code Marketplace.

karinzaa commented 3 months ago

@karinzaa @jassriver I've just published a version 5.6.0 on the VS Code Marketplace. I've changed two settings in the build configuration which have been changed between 5.5.0 and 5.5.1. Maybe it fixes your issue. Feel free to try it out once it's available for you to install it via VS Code Marketplace.

Now I update via VS Code Marketplace it work well. Thank 🙏

PKief commented 3 months ago

@karinzaa @jassriver I've just published a version 5.6.0 on the VS Code Marketplace. I've changed two settings in the build configuration which have been changed between 5.5.0 and 5.5.1. Maybe it fixes your issue. Feel free to try it out once it's available for you to install it via VS Code Marketplace.

Now I update via VS Code Marketplace it work well. Thank 🙏

Awesome 👍

jassriver commented 3 months ago

@PKief To perform the final test, I completely deleted the extension and installed it through the vscode marketplace, I installed version 5.5.1 and all the icons were working normally (strange, right?) so I removed the extension folder from my file explorer and installed it the extension again and again, the 5.5.1 icons were there without any problem O.o What???

Anyway, 5.6.0 seems to have fixed the problem, or else downloading the VSIX you provided resolved the problem in some magical way (I would need someone who was having the problem to not download VSIX file and directly install version 5.6.0 to say that this actually solved the problem) But, you can close this Issue now, I think.

It could also be that the distributed marketplace has a version of the extension that has a problem for some users (but I can't say if this is likely)

Thanks for the resolution PKief 🙏

ehduardu commented 3 months ago

I still have this issue in version 5.6.0

I changed to version v5.5.1 via the VSIX file and it's working, but when I update to the new version, the problem comes back.

UPDATE: I've updated my VSCode to the last version and this has been resolved.

Cecil0o0 commented 3 months ago

It seems vscode couldn't find the folder-i18n svg in our extension, which introduced this bug, while folder svg works fine~ if missed several icons when build the vsix?

PKief commented 3 months ago

@Cecil0o0 I've checked the vsix file as well, but it contains the files correctly:

I've tested the extension on three different machines (Windows, MacOS) and everywhere it's working fine with the latest version. That's why I'm a bit confused why for some people it's not working as expected 🧐

Can you try to bring your VS Code instance to the latest version and also delete the material-icon-theme from the extension folder manually and install it again?

thresh111 commented 3 months ago

I had the same problem and it happened within a week. 😂

version ： 5.6 ， but version ： 5.51 not this bug

coderwyd commented 3 months ago

We can only temporarily return to v5.5.1. There are still problems with the latest version.

Xicatto commented 3 months ago

This problem is still persisting in version 5.6.0. At least on macOS. After installing v5.5.1 on macOS the icons show up.

v5.6.0

v5.5.1

okineadev commented 3 months ago

I don't know why, but for some reason, some icons just mysteriously disappeared from me too

https://github.com/user-attachments/assets/fa30b3b2-b8ba-40b1-a53b-323254081b78

karinzaa commented 3 months ago

@PKief Now I back the same issues that used to be has randomly returned again.

PKief commented 3 months ago

I don't know why, but for some reason, some icons just mysteriously disappeared from me too

https://github.com/user-attachments/assets/fa30b3b2-b8ba-40b1-a53b-323254081b78

It looks weird. Like a rendering issue or something... I double checked the code that was changed between the versions 5.5.0 and 5.6.0 and still can't figure out what causes this issue.

okineadev commented 3 months ago

I don't know why, but for some reason, some icons just mysteriously disappeared from me too
2024-07-18.175342.mp4
It looks weird. Like a rendering issue or something... I double checked the code that was changed between the versions 5.5.0 and 5.6.0 and still can't figure out what causes this issue.

Quite likely. This is most likely a vscode issue, so I think we should move this issue to the vscode repo

danielabar commented 3 months ago

This just started happening for me as well. The Ruby icons for .rb files are no longer displaying. A few others like .ruby-version and config.ru are also missing.

I think it started happening after applying latest VSCode update.

macOS 14.5

Material Icon Theme: v5.6.0

VSCode: Version: 1.91.1 (Universal) Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729 Date: 2024-07-09T22:07:54.982Z Electron: 29.4.0 ElectronBuildId: 9728852 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Darwin arm64 23.5.0

okineadev commented 3 months ago

This just started happening for me as well. The Ruby icons for .rb files are no longer displaying. A few others like .ruby-version and config.ru are also missing.

I think it started happening after applying latest VSCode update.

macOS 14.5

Material Icon Theme: v5.6.0

VSCode: Version: 1.91.1 (Universal) Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729 Date: 2024-07-09T22:07:54.982Z Electron: 29.4.0 ElectronBuildId: 9728852 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Darwin arm64 23.5.0

Create this issue in the vscode repo

nbbaier commented 3 months ago

Just want to report that this is happening for me in 5.6.0 on one of my machines but not another. On the machine it is happening, regressing to 5.5.1 addresses the issue!

Cecil0o0 commented 3 months ago

@Cecil0o0 I've checked the vsix file as well, but it contains the files correctly:

I've tested the extension on three different machines (Windows, MacOS) and everywhere it's working fine with the latest version. That's why I'm a bit confused why for some people it's not working as expected 🧐

Can you try to bring your VS Code instance to the latest version and also delete the material-icon-theme from the extension folder manually and install it again?

Version: 1.91.1 (Universal) Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729 Date: 2024-07-09T22:07:54.982Z Electron: 29.4.0 ElectronBuildId: 9728852 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Darwin x64 23.5.0

@PKief Copied about my VS Code instance, and I do this manually, downloading from your link at release page, but finally reproduce this is issue again...

here is my finder on my machine, folder.svg exists but folder-i18n.svg not.

totally 936 items in icons folder of vsix, is this count right?

PKief commented 3 months ago

@Cecil0o0 I've checked the vsix file as well, but it contains the files correctly: I've tested the extension on three different machines (Windows, MacOS) and everywhere it's working fine with the latest version. That's why I'm a bit confused why for some people it's not working as expected 🧐 Can you try to bring your VS Code instance to the latest version and also delete the material-icon-theme from the extension folder manually and install it again?

Version: 1.91.1 (Universal) Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729 Date: 2024-07-09T22:07:54.982Z Electron: 29.4.0 ElectronBuildId: 9728852 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Darwin x64 23.5.0

@PKief Copied about my VS Code instance, and I do this manually, downloading from your link at release page, but finally reproduce this is issue again...

here is my finder on my machine, folder.svg exists but folder-i18n.svg not.

totally 936 items in icons folder of vsix, is this count right?

yes 936 is the correct amount at this moment.

PKief commented 3 months ago

This just started happening for me as well. The Ruby icons for .rb files are no longer displaying. A few others like .ruby-version and config.ru are also missing. I think it started happening after applying latest VSCode update. macOS 14.5 Material Icon Theme: v5.6.0 VSCode: Version: 1.91.1 (Universal) Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729 Date: 2024-07-09T22:07:54.982Z Electron: 29.4.0 ElectronBuildId: 9728852 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Darwin arm64 23.5.0

Create this issue in the vscode repo

As this issue was happening for you too, would you mind creating an issue at the VS Code repository with the video which you posted here? And if some of the icons are not shown properly, can you check if these icons are either present or do have content in the extensions directory? E.g. extension folder icon is not shown -> is the folder-plugin.svg file present in the ~/.vscode/extensions/pkief.material-icon-theme-5.6.0/icons directory? It would be a valuable information, also for the VS Code team to figure out what the issue is. At the moment, I'm a bit confused what to do from extension owner perspective, as the problem is just occuring sometimes, on some machines. It's pretty much hard to reproduce.

vonsofh commented 3 months ago

For now I would install another version that is 5.5.1

PKief commented 3 months ago

For now I would install another version that is 5.5.1

You mean 5.5.1 is working, but 5.6.0 is not? But as the first post of this issue shows this issue also occurred with v5.5.1. Will it also happen with 5.5.0? It seems like this issue started with 5.5.1, not with 5.6.0

vonsofh commented 3 months ago

For now I would install another version that is 5.5.1

You mean 5.5.1 is working, but 5.6.0 is not? But as the first post of this issue shows this issue also occurred with v5.5.1. Will it also happen with 5.5.0? It seems like this issue started with 5.5.1, not with 5.6.0

Yep, the previous version 5.5.1 working well for me.

The latest 5.6.0, shows no icon for some files, in my case .php

scripthly commented 3 months ago

Having the same issue. Downgrading to 5.5.1 seems to fix it.

5.6.0

5.5.1

okineadev commented 3 months ago

Could it be due to a download failure? I wonder if vscode checks the checksum of the extension before installing

PKief commented 3 months ago

@okineadev are the icons empty or missing in the extensions folder?

okineadev commented 3 months ago

@okineadev are the icons empty or missing in the extensions folder?

The extensions icon is missing, but the open folder icon is present

danielabar commented 3 months ago

For me, reverting to 5.5.1 brings back all the icons.

lucas-labs commented 3 months ago

This is a long shot but, have you guys tried completely uninstalling the extension (making sure that ~/user/.vscode/pkief.material-icon-theme-x.x.x was removed, and manually removing it if it wasn't) and installing it again? Also try to remove all settings related with the extension before reinstalling. Since the extension manipulates the .svg files depending on some of the settings, maybe one of them might be causing an issue causing the icons to be empty).

Also, sharing your settings.json might help on trying to reproduce it. So far, I wasn't able to reproduce this issue at all.

Cecil0o0 commented 3 months ago

@Cecil0o0 I've checked the vsix file as well, but it contains the files correctly: I've tested the extension on three different machines (Windows, MacOS) and everywhere it's working fine with the latest version. That's why I'm a bit confused why for some people it's not working as expected 🧐 Can you try to bring your VS Code instance to the latest version and also delete the material-icon-theme from the extension folder manually and install it again?

Version: 1.91.1 (Universal) Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729 Date: 2024-07-09T22:07:54.982Z Electron: 29.4.0 ElectronBuildId: 9728852 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Darwin x64 23.5.0 @PKief Copied about my VS Code instance, and I do this manually, downloading from your link at release page, but finally reproduce this is issue again... here is my finder on my machine, folder.svg exists but folder-i18n.svg not. totally 936 items in icons folder of vsix, is this count right?

yes 936 is the correct amount at this moment.

@PKief, after I came home and opened my machine, folder-i18n.svg just appears in pkief.material-icon-theme-5.6.0/icons....

Now I couldn't reproduce this again even toggling between 5.6.0 and 5.5.1, I guess my problem just disappeared, 🙏 thanks for reply.

kie4280 commented 3 months ago

This is a long shot but, have you guys tried completely uninstalling the extension (making sure that ~/user/.vscode/pkief.material-icon-theme-x.x.x was removed, and manually removing it if it wasn't) and installing it again? Also try to remove all settings related with the extension before reinstalling. Since the extension manipulates the .svg files depending on some of the settings, maybe one of them might be causing an issue causing the icons to be empty).

Also, sharing your settings.json might help on trying to reproduce it. So far, I wasn't able to reproduce this issue at all.

I can confirm that uninstalling the extension, removing the folder ~/user/.vscode/pkief.material-icon-theme-x.x.x and reinstalling the extension resolves the problem of disappearing icons in ver. 5.6.0.

nbbaier commented 3 months ago

I can also confirm this

Kurzdor commented 3 months ago

Hi there! Also happened to me just right now. Some of the icons were 0kb, deleting folders and reinstalling extension helped. Looks like some VS Code issue that break assets inside the VSIX extension.

TristanKatwaroo commented 3 months ago

All my icons were missing except for standard folder icons for a few days, but it seems the issue only applies to 5.6.0. Downgrading to 5.5.1 resolves the issue for me. Additionally, my VS Code is up to date.

Saya47 commented 3 months ago

Maybe you should revert the updates for now as this makes a lot of confusion as to why icons are not showing...

Yamazaki93 commented 3 months ago

Encountering the same issue here, VSCode 1.91.1 Windows 11. With 5.6.0 several icons (e.g. src folder, gitattributes, gitignore, md, cfg) are missing. Reverted back to 5.5.1 and the issue is resolved.

vonsofh commented 3 months ago

~/user/.vscode/pkief.material-icon-theme-x.x.x

This solution is work

material-extensions / vscode-material-icon-theme