material-extensions / vscode-material-icon-theme

Available on the VSCode Marketplace
https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme
MIT License
2.02k stars 622 forks source link

[Bug] Some icons are not displayed #2428

Closed jassriver closed 1 month ago

jassriver commented 2 months ago

Describe the bug

Some icons are not displayed in version 5.5.1 image

The config folder icon show when I open it, but seeders and other folders are not displayed even when opened image

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'extensions'
  2. Click on config in 'Material Icon Theme'
  3. Click on 'Install Another Version'
  4. install 5.5.1 version
  5. See the bug.

Expected behavior

display the icons as always. One way to get around this is to install another version, in this case 5.5.0 works correctly.

Computer information (please complete the following information)

Other information

I've already uninstalled and installed the extension, I've selected the icon theme, I've enabled and re-enabled it, I've restarted the extensions, I've closed and opened vscode, I've restarted my computer and nothing has changed.

yenche123 commented 1 month ago

I can confirm that uninstalling the extension, removing the folder ~/user/.vscode/pkief.material-icon-theme-x.x.x and reinstalling the extension resolves the problem of disappearing icons in ver. 5.6.0.

ya! it works for me too! it was just like:

# at the current user's root
cd .vscode/extensions
sudo rm -r pkief.material-icon-theme-5.6.0
vanClausen commented 1 month ago

Had the same issue with 5.6.0 Uninstall and reinstalling via VSIX solved the problem for me

danechitoaie commented 1 month ago

Same problem for me. Some icons randomly disappear. If I uninstall the ext and then install it back it fixes the issue for a short while and then they disappear again.

VSC Version: 1.91.1 (Universal) OS: Darwin arm64 23.5.0 Material Icon Theme: v5.7.0

PKief commented 1 month ago

Same problem for me. Some icons randomly disappear. If I uninstall the ext and then install it back it fixes the issue for a short while and then they disappear again.

VSC Version: 1.91.1 (Universal) OS: Darwin arm64 23.5.0 Material Icon Theme: v5.7.0

With "uninstall" do you mean just clicking the "Uninstall"-button in the UI or the proposed delete commands:

# at the current user's root
cd .vscode/extensions
sudo rm -r pkief.material-icon-theme-5.7.0

Would be helpful if you could specify your steps.

PKief commented 1 month ago

@PKief, after I came home and opened my machine, folder-i18n.svg just appears in pkief.material-icon-theme-5.6.0/icons....

Now I couldn't reproduce this again even toggling between 5.6.0 and 5.5.1, I guess my problem just disappeared, 🙏 thanks for reply.

Did the issue occur again or is it solved for you completely and didn't come back? 🧐

danechitoaie commented 1 month ago

Same problem for me. Some icons randomly disappear. If I uninstall the ext and then install it back it fixes the issue for a short while and then they disappear again. VSC Version: 1.91.1 (Universal) OS: Darwin arm64 23.5.0 Material Icon Theme: v5.7.0

With "uninstall" do you mean just clicking the "Uninstall"-button in the UI or the proposed delete commands:

# at the current user's root
cd .vscode/extensions
sudo rm -r pkief.material-icon-theme-5.7.0

Would be helpful if you could specify your steps.

Initially I uninstalled it from VSC, restarted and then installed it back. Then I deleted the whole ~/.vscode folder and installed the extension back.

And now I've uninstalled it from the VSC UI, and then installed it back from .vsix file. For now it works. I'll update if icons start disappearing again.

danechitoaie commented 1 month ago

It just disappeared again.

Screenshot 2024-07-23 at 01 26 17
danechitoaie commented 1 month ago

Here's a listing of the icons folders after a fresh install and after it breaks:

drwxr-xr-x  945 daniels  staff    30K Jul 23 01:33 .
drwxr-xr-x   25 daniels  staff   800B Jul 23 01:33 ..
-rw-r--r--    1 daniels  staff   398B Jul 23 01:33 3d.svg
-rw-r--r--    1 daniels  staff   110B Jul 23 01:33 abap.svg
-rw-r--r--    1 daniels  staff   768B Jul 23 01:33 abc.svg
-rw-r--r--    1 daniels  staff   766B Jul 23 01:33 actionscript.svg
-rw-r--r--    1 daniels  staff   360B Jul 23 01:33 ada.svg
-rw-r--r--    1 daniels  staff   262B Jul 23 01:33 adonis.svg
-rw-r--r--    1 daniels  staff   775B Jul 23 01:33 advpl-include.clone.svg
-rw-r--r--    1 daniels  staff   775B Jul 23 01:33 advpl-ptm.clone.svg
-rw-r--r--    1 daniels  staff   775B Jul 23 01:33 advpl-tlpp.clone.svg
-rw-r--r--    1 daniels  staff   775B Jul 23 01:33 advpl.svg
-rw-r--r--    1 daniels  staff   151B Jul 23 01:33 amplify.svg
-rw-r--r--    1 daniels  staff   516B Jul 23 01:33 android.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:33 angular-component.clone.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:33 angular-directive.clone.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:33 angular-guard.clone.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:33 angular-pipe.clone.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:33 angular-resolver.clone.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:33 angular-service.clone.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:33 angular.svg
-rw-r--r--    1 daniels  staff   823B Jul 23 01:33 antlr.svg
-rw-r--r--    1 daniels  staff   363B Jul 23 01:33 apiblueprint.svg
-rw-r--r--    1 daniels  staff   451B Jul 23 01:33 apollo.svg
-rw-r--r--    1 daniels  staff   608B Jul 23 01:33 applescript.svg
-rw-r--r--    1 daniels  staff   785B Jul 23 01:33 apps-script.svg
-rw-r--r--    1 daniels  staff   780B Jul 23 01:33 appveyor.svg
-rw-r--r--    1 daniels  staff   762B Jul 23 01:33 architecture.svg
-rw-r--r--    1 daniels  staff   426B Jul 23 01:33 arduino.svg
-rw-r--r--    1 daniels  staff   291B Jul 23 01:33 asciidoc.svg
-rw-r--r--    1 daniels  staff   417B Jul 23 01:33 assembly.svg
drwxr-xr-x  945 daniels  staff    30K Jul 23 01:33 .
drwxr-xr-x   25 daniels  staff   800B Jul 23 01:33 ..
-rw-r--r--    1 daniels  staff     0B Jul 23 01:48 3d.svg
-rw-r--r--    1 daniels  staff   110B Jul 23 01:48 abap.svg
-rw-r--r--    1 daniels  staff   768B Jul 23 01:48 abc.svg
-rw-r--r--    1 daniels  staff   766B Jul 23 01:48 actionscript.svg
-rw-r--r--    1 daniels  staff   360B Jul 23 01:48 ada.svg
-rw-r--r--    1 daniels  staff   262B Jul 23 01:48 adonis.svg
-rw-r--r--    1 daniels  staff   775B Jul 23 01:48 advpl-include.clone.svg
-rw-r--r--    1 daniels  staff   775B Jul 23 01:48 advpl-ptm.clone.svg
-rw-r--r--    1 daniels  staff   775B Jul 23 01:48 advpl-tlpp.clone.svg
-rw-r--r--    1 daniels  staff   775B Jul 23 01:48 advpl.svg
-rw-r--r--    1 daniels  staff   151B Jul 23 01:48 amplify.svg
-rw-r--r--    1 daniels  staff   516B Jul 23 01:48 android.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:48 angular-component.clone.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:48 angular-directive.clone.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:48 angular-guard.clone.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:48 angular-pipe.clone.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:48 angular-resolver.clone.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:48 angular-service.clone.svg
-rw-r--r--    1 daniels  staff   263B Jul 23 01:48 angular.svg
-rw-r--r--    1 daniels  staff   823B Jul 23 01:48 antlr.svg
-rw-r--r--    1 daniels  staff   363B Jul 23 01:48 apiblueprint.svg
-rw-r--r--    1 daniels  staff   451B Jul 23 01:48 apollo.svg
-rw-r--r--    1 daniels  staff   608B Jul 23 01:48 applescript.svg
-rw-r--r--    1 daniels  staff   785B Jul 23 01:48 apps-script.svg
-rw-r--r--    1 daniels  staff   780B Jul 23 01:48 appveyor.svg
-rw-r--r--    1 daniels  staff   762B Jul 23 01:48 architecture.svg
-rw-r--r--    1 daniels  staff   426B Jul 23 01:48 arduino.svg
-rw-r--r--    1 daniels  staff     0B Jul 23 01:48 asciidoc.svg
-rw-r--r--    1 daniels  staff   417B Jul 23 01:48 assembly.svg

3d.svg and asciidoc.svg now have 0 bytes and some others not pasted here. Also the timestamp of the files changed as well (Jul 23 01:33 when I reinstalled the extension vs Jul 23 01:48 when files broke).

okineadev commented 1 month ago

Well, this is clearly a vscode problem

okineadev commented 1 month ago

With "uninstall" do you mean just clicking the "Uninstall"-button in the UI or the proposed delete commands:

# at the current user's root
cd .vscode/extensions
sudo rm -r pkief.material-icon-theme-5.7.0

*

cd ~/.vscode/extensions
sudo rm -rf pkief.material-icon-theme-5.7.0
PKief commented 1 month ago

@danechitoaie are you using any of the settings for the extension?

PKief commented 1 month ago

Well, this is clearly a vscode problem

Yeah even I'm thinking that. It's weird that 15min after installing the extension some icons are with 0 bytes 😕

okineadev commented 1 month ago

Well, this is clearly a vscode problem

Yeah even I'm thinking that. It's weird that 15min after installing the extension some icons are with 0 bytes 😕

Has anyone even created an issue in vscode with this bug?

danechitoaie commented 1 month ago

@danechitoaie are you using any of the settings for the extension?

No. Just default install without changing any settings.

danechitoaie commented 1 month ago

Well, this is clearly a vscode problem

Yeah even I'm thinking that. It's weird that 15min after installing the extension some icons are with 0 bytes 😕

Even more weird is that the files keep being accessed by something and randomly emptying some of them even though since last night I installed and activated different extension for icons.

-rw-r--r--    1 daniels  staff   1.1K Jul 23 11:32 auto_light.svg
-rw-r--r--    1 daniels  staff   1.3K Jul 23 11:32 autohotkey.svg
-rw-r--r--    1 daniels  staff   438B Jul 23 11:32 autoit.svg
-rw-r--r--    1 daniels  staff   803B Jul 23 11:32 azure-pipelines.svg
-rw-r--r--    1 daniels  staff   617B Jul 23 11:32 azure.svg
-rw-r--r--    1 daniels  staff   1.3K Jul 23 11:32 babel.svg
-rw-r--r--    1 daniels  staff   204B Jul 23 11:32 ballerina.svg
-rw-r--r--    1 daniels  staff   620B Jul 23 11:32 bazel.svg
-rw-r--r--    1 daniels  staff     0B Jul 23 11:32 bicep.svg
-rw-r--r--    1 daniels  staff     0B Jul 23 11:32 biome.svg
-rw-r--r--    1 daniels  staff   647B Jul 23 11:32 bitbucket.svg
-rw-r--r--    1 daniels  staff   2.0K Jul 23 11:32 bithound.svg
-rw-r--r--    1 daniels  staff   1.4K Jul 23 11:32 blink.svg
-rw-r--r--    1 daniels  staff   1.5K Jul 23 11:32 blink_light.svg
-rw-r--r--    1 daniels  staff   358B Jul 23 11:32 blitz.svg
-rw-r--r--    1 daniels  staff   3.7K Jul 23 11:32 bower.svg
-rw-r--r--    1 daniels  staff   1.9K Jul 23 11:32 brainfuck.svg

Weirdly this other extensions doesn't seem to be having (at least yet) the issue of missing icons. The files timestamp still remains that of when I installed it:

-rw-r--r--     1 daniels  staff   1.0K Jul 23 03:35 folder_type_vscode_test_opened.svg
-rw-r--r--     1 daniels  staff   887B Jul 23 03:35 folder_type_webpack.svg
-rw-r--r--     1 daniels  staff   1.0K Jul 23 03:35 folder_type_webpack_opened.svg
-rw-r--r--     1 daniels  staff   366B Jul 23 03:35 folder_type_windows.svg
-rw-r--r--     1 daniels  staff   467B Jul 23 03:35 folder_type_windows_opened.svg
-rw-r--r--     1 daniels  staff   810B Jul 23 03:35 folder_type_wit.svg
-rw-r--r--     1 daniels  staff   862B Jul 23 03:35 folder_type_wit_opened.svg
-rw-r--r--     1 daniels  staff   8.9K Jul 23 03:35 folder_type_www.svg
-rw-r--r--     1 daniels  staff   9.0K Jul 23 03:35 folder_type_www_opened.svg
lucas-labs commented 1 month ago

Even more weird is that the files keep being accessed by something and randomly emptying some of them even though since last night I installed and activated different extension for icons.

Sadly, I wasn't able to reproduce anything that has been reported in this issue so far. It's weird. If I understood this correctly, the issue happens even when the extension is disabled? If that's the case, it cannot be this extension what's causing it, since the code from this extensions can't run if the extension is disabled... It has to either be vscode itself or another extension accessing the files.

In my case, the timestamp haven't changed since I installed it.

.rwxrwx--- lucas  398B 19 Jul 24 19:41:03 3d.svg
.rwxrwx--- lucas  110B 19 Jul 24 19:41:03 abap.svg
.rwxrwx--- lucas  768B 19 Jul 24 19:41:03 abc.svg
.rwxrwx--- lucas  766B 19 Jul 24 19:41:03 actionscript.svg
.rwxrwx--- lucas  360B 19 Jul 24 19:41:03 ada.svg
.rwxrwx--- lucas  262B 19 Jul 24 19:41:03 adonis.svg
...

@Pkief, note aside, have you ever thought of adding logging to the extension using a vscode output channel?

Image

It could help to easily identify issues in the future. We could make it disabled by default and ask people reporting issues to activate it and share their logs.

PKief commented 1 month ago

@PKief, note aside, have you ever thought of adding logging to the extension using a vscode output channel?

Image It could help to easily identify issues in the future. We could make it disabled by default and ask people reporting issues to activate it and share their logs.

Even I'm not able to reproduce any of the reported issues here so far (I'm using different machines and all are fine). That's why I think adding a logging functionality is a super good idea. I'm working on it and will provide a solution soon!

gilluminate commented 1 month ago

This happened to me today. I removed the Material Icon Theme extenstion then quit and restarted VS Code and then reinstalled the extension and it fixed everything. My suspicion is that it has something to do with VS Code moving toward a "Restart Extensions" instead of "Restart VS Code" when updating extensions.

shanoor commented 1 month ago

This happened to me today. I removed the Material Icon Theme extenstion then quit and restarted VS Code and then reinstalled the extension and it fixed everything. My suspicion is that it has something to do with VS Code moving toward a "Restart Extensions" instead of "Restart VS Code" when updating extensions.

Same here, I avoided to click the "Restart extensions" button and restarted vscodium instead, it works now with version 5.7.0.

karinzaa commented 1 month ago

@PKief In v5.7.0 issues is not fix it randon bug again.

Screenshot 2024-07-24 211246

I used delete folders method to fix it come back.

image
ReedSchroeder commented 1 month ago

Just throwing my two cents in here, I seem to be having this problem in version 5.7.0. If I downgrade to 5.6.0 and press "restart extensions", it seems to fix itself.

PKief commented 1 month ago

🔉I've just released v.5.8.0 with a few fixes. While analysing the code, I noticed that a couple of operations have been performed too much on the SVG icons, even though there were no settings at all. So if you use the extension out of the box, you should no longer have any problems with the latest update.

I would like to thank everyone who has actively participated here and hope that the problem will no longer occur with the new version. Please let us know if you continue to have problems with this.

ReedSchroeder commented 1 month ago

Just installed, it seems to have fixed the problem for me. Thanks!

danechitoaie commented 1 month ago

I've updated to v5.8.0 as well. I'll report if I notice any issues anymore. For now it seems good. Thank you.

glundgrenm commented 1 month ago

5.8.0 fixed the bug for me

PKief commented 1 month ago

Closing the ticket as v5.8.0 has resolved it.