search

material-motion-archive / direct-manipulation-swift

Archived February 16, 2017 :: Direct Manipulation for Apple devices
Apache License 2.0
1 stars 1 forks source link

Move performer logic to private/ dir #19

Closed jverkoey closed 8 years ago

jverkoey commented 8 years ago

All performer logic should be added to swift files in the src/private sub-directory.

See the Core Animation family for an example: https://github.com/material-motion/material-motion-family-coreanimation-swift/tree/develop/src/private

rcameron commented 8 years ago

Would be worthwhile to mimic the Swift access levels model and call it src/internal since performers will most likely be internal?

jverkoey commented 8 years ago

Oh! Interesting question. Our src/private concept comes from our Objective-C conventions. I could get behind introducing a src/internal distinction for swift conventions.

Can you start a discussion about this on the team repo?

jverkoey commented 8 years ago

🎊 My diff is ready for review at http://codereview.cc/D1814