search

mathieu-mp / homeassistant-intex-spa

Home Assistant integration for Intex Spa
https://github.com/mathieu-mp/homeassistant-intex-spa
MIT License
32 stars 6 forks source link

Translation does not fall back to English when the user's language is not covered #53

Closed Chaos02 closed 5 months ago

Chaos02 commented 1 year ago

Version of the custom_component

Configuration

default_config:

# various scripts and automation imports, all working

Describe the bug

I see you've put effort into error codes and their translations but in home assistant the states of the error entities actually are just the lower case codes for me.

In case it wasn't thought of before I'd also appreciate it falling back to English, if a translation of your language isn't available yet.

(My HA instance is set to Germany, English)

I will provide a German translation pull request shortly!

Debug log


Logs following soon but probably not needed
mathieu-mp commented 1 year ago

Hi @Chaos02,

Thank you again for providing a German translation !

I'd also expect the fallback to English to work as-is. It looks like the current translations implementation is deprecated for this integration.

This issue will require some work, but it has to be done !

mathieu-mp commented 5 months ago

Fixed by #86