search

matmair / brother_ql-inventree

Python package for the raster language protocol of the Brother QL series label printers
GNU General Public License v3.0
22 stars 9 forks source link

Network backend updates #29

Closed bloemp closed 1 year ago

bloemp commented 1 year ago

Hi @matmair, I've updated the network backend to allow networked printers be discoverable through SNMP and report back its status. The reason for starting this PR is so we can modify the inventree-brother plugin to at least use auto-detect for its media type (changing it in the settings for different type of labels is cumbersome). And maybe even use the auto-discover for easy access (but SNMP broadcasts from a docker container needs --network=host). I know that this a fork of the original, but as the original is basically unmaintained, I thought I would directly PR it to you.

matmair commented 1 year ago

@bloemp I have a few questions. In general, I am a bit hesitant about this change. I do not have access to a network-based printer currently so it is hard for me to gauge how/if this breaks anything. Would you be able to also open a PR against upstream? I know the maintainer is not very responsive but if that changes I would like to phase out this fork ASAP.

bloemp commented 1 year ago

@matmair I've updated the PR with your input (which is very much appreciated). I understand why you are hesitant to merge this as you can't test it yourself and would rather see this fork disappear asap. Therefore, I think it is best to close this PR and create one against the original repo. Hopefully, someone can test is there, and the original maintainer will merge in the future.

matmair commented 1 year ago

@bloemp if we find a second user that can verify I am happy to merge, I appreciate the work you put into discovery. I will put a note in the next InvenTree newsletter (should go out at the end of January).

matmair commented 1 year ago

It is more about having multiple environments then thinking the code is wrong. Hardware interfaces are tricky.