search

matomo-org / tag-manager

Free Open Source Matomo Tag Manager - A simple way to manage and maintain all of your (third-party) tags on your website.
https://matomo.org
GNU General Public License v3.0
174 stars 58 forks source link

Improve description of HistoryChangeTrigger #63

Closed Findus23 closed 6 years ago

Findus23 commented 6 years ago

https://github.com/matomo-org/tag-manager/blob/d90ff5716982769a02faf48ace9d1d5289f1d32f/lang/en.json#L256

While it is clear to me that a change to windows.location is meant, the wording isn't perfectly clear and can be misunderstood as e.g. in the German translation:

https://github.com/matomo-org/tag-manager/blob/f233a84c28e441973c935f8f5f42b1d67fa89314/lang/de.json#L229

I don't have a perfect solution, but maybe the straightforward Triggered when the current URL changes. is more understandable and clear enough.

tsteur commented 6 years ago

Sounds good 👍 Did you want to create a PR for this?