search

matomo-org / tag-manager

Free Open Source Matomo Tag Manager - A simple way to manage and maintain all of your (third-party) tags on your website.
https://matomo.org
GNU General Public License v3.0
173 stars 58 forks source link

[Bug] MTM debugger marks incorrect tab with active HTML class #758

Open skyhhjmk opened 8 months ago

skyhhjmk commented 8 months ago

Reproduction process

First, make sure you're in debug mode

Clip_2024-02-22_21-34-48

Use Ctrl F5 to force a refresh on your website to ensure that the resources required for debug mode load correctly

Later you will find that from the CSS, I selected the bottom tab, but it actually shows the content of the first tab, and I really chose the first one

Clip_2024-02-22_21-37-17

snake14 commented 8 months ago

Hi @skyhhjmk . Thank you for the description of the issue. I just tried to reproduce the issue you described, but was unable to. I tested with Matomo 5.0.2. What version of Matomo are you using? Any other context that you can provide?

skyhhjmk commented 8 months ago

matomo_system_check.txt

this file is from here:

Clip_2024-02-23_14-49-28

snake14 commented 8 months ago

Hmm. Looks like Matomo 5.0.2 as well. I tried enabling many of the plugins listed as enabled, but I was still unable to reproduce the issue. Any ideas @AltamashShaikh ?

AltamashShaikh commented 8 months ago

@snake14 @skyhhjmk Unable to reproduce it, @skyhhjmk Is there any URL where we can see this behaviour ?

skyhhjmk commented 8 months ago

I weighed the pros and cons and finally decided to leave debug mode open for about 1 week to help you guys look into this weird issue

biliwind.com on debug mode

And... I'm still not sure if debug mode will affect the security of my site, so I'll still turn off debug mode if I find a serious security issue during this period

skyhhjmk commented 8 months ago

Well, I thought of another possibility, maybe because of the browser language? but I'm sorry I didn't have enough time to test this idea, my browser is in Chinese Simplified, which is zh-cn (in some places it's zh-hans)

snake14 commented 8 months ago

Hi @skyhhjmk . Thank you for the additional information. Inspecting your site, it looks like the tags are sorted correctly. It even displays the correct tag when you click on the tab. The issue is that the wrong tab is highlighted, and I was able to partially reproduce that in my local environment. It appears that we hadn't noticed that the active class was added to the wrong tab because our default styling doesn't highlight the active tab like it does on your site. I'm marking this issue as a bug to be prioritised by our Product team.