Closed snake14 closed 4 months ago
@snake14 All looks good, the only difference I see is this code moved to top from previous code, should we move to bottom again ? Rest all looks good to be merged
Thanks @AltamashShaikh . I intentionally moved those lines because I didn't think that they were in the right place. It probably doesn't really matter, though. What do you think?
@snake14 All looks good, the only difference I see is this code moved to top from previous code, should we move to bottom again ? Rest all looks good to be merged
@snake14 It should not matter :+1:
@matomo-org/core-team I just merged this PR. Can we please make sure that it gets tagged for the next 5.1.0 beta release?
This reverts commit 1eed6a4df5a3038111b4ba4d9afc51636bc7689b, reversing changes made to 5cb1114986a4a0b487c2ca2984fbbeea048aef7a.
Description:
Reverting the MTM changes to try making it work better with _paq.push. The changes are once again causing unexplained data loss.
Review