Open AltamashShaikh opened 4 days ago
I added a test for Clipboard copy, but facing same as what we are facing in CrashAnalytics so removed the test.
@AltamashShaikh Weren't the changes in https://github.com/matomo-org/matomo/pull/22332 meant for making that possible?
@AltamashShaikh Weren't the changes in matomo-org/matomo#22366 meant for making that possible?
@sgiehl If you checkout this PR and click Install Code under TagManager menu and try to copy the MTM code by clicking copy button, it will not copy anything. On debugging I found out that we need to set focus to allow it to copy.
So the changes in matomo-org/matomo#22366 adds only the focus to make copy work in modal. Puppeter issue is different.
@sgiehl Sadly, https://github.com/matomo-org/matomo/pull/22332 didn't solve the Puppeteer issue as I had hoped, either.
Description:
Add copy button in install code screen Fixes: #812 & #PG-3520 Require: https://github.com/matomo-org/matomo/pull/22366
Review