matomo-org / tag-manager

Free Open Source Matomo Tag Manager - A simple way to manage and maintain all of your (third-party) tags on your website.
https://matomo.org
GNU General Public License v3.0
170 stars 58 forks source link

Pg 3565 add field placeholders #841

Closed snake14 closed 1 month ago

snake14 commented 2 months ago

Description:

Product wanted placeholders added to all free-form inputs so that the label is always above the input. The PR does that.

Since I was already editing the necessary Vue templates for a couple other tickets, I implemented those as part of this PR as well.

Full changes:

Internal tickets:

Review

araichyk commented 2 months ago

Maybe missing a placeholder on this one under the "Show advanced settings" in VariableEdit.vue:

https://github.com/matomo-org/tag-manager/blob/4b989af8b0e2bb288b4e21a86363092d16f2a88f/vue/src/Variable/VariableEdit.vue#L99-L106

snake14 commented 2 months ago

Maybe missing a placeholder on this one under the "Show advanced settings" in VariableEdit.vue:

https://github.com/matomo-org/tag-manager/blob/4b989af8b0e2bb288b4e21a86363092d16f2a88f/vue/src/Variable/VariableEdit.vue#L99-L106

@araichyk Good catch. I went ahead and added one :+1: