The test basically fails, as for TiDb the order of returned items is different. For MySQL the order seems automatically ordered by idsite and idcontainer, for TiDb this isn't the case.
[ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
[ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
Description:
While running core tests for TiDb, we came across a failing test for TagManager:
https://github.com/matomo-org/tag-manager/blob/691169cfb2b187d19eea339a5e368f3b4810a846/tests/Integration/Dao/ContainerReleaseDaoTest.php#L470-L493
The test basically fails, as for TiDb the order of returned items is different. For MySQL the order seems automatically ordered by
idsite
andidcontainer
, for TiDb this isn't the case.Adding an explicit
order by
to the query ensures the same results across different database engines.Review