search

matomo-org / tag-manager

Free Open Source Matomo Tag Manager - A simple way to manage and maintain all of your (third-party) tags on your website.
https://matomo.org
GNU General Public License v3.0
170 stars 58 forks source link

Remove hidden limitation on Container Publish Capability #893

Open Stan-vw opened 1 week ago

Stan-vw commented 1 week ago

When I looked at the MTM permission system (under System>User>Capabilities), the attached combination of user permissions is what I expected between the "Use Custom Templates capability" and "Publish Live Container capability": image

However this is not the case. Currently, the bottom left square also has the hidden limitation

But cannot publish a container with custom templates

That means that the Publish button does not show up for users with Publish Live Container capability when someone has added/updated a custom tag/trigger/variable in the container. For them, the navbar shows up as: image

Suggested change: remove this hidden limitation to align the actual capabilities with the wording of the capabilities. Note: this does mean that users with Publish Live Container capability now are responsible for the quality of the custom templates that go live. This aligns with a RACI matrix where the approver isn't always the one that is allowed to create the object that gets approved.

atom-box commented 1 week ago

This sounds great to me. (I contacted now the person who raised this concern. I will soon post here or they will post further thoughts.)

atom-box commented 1 week ago

The person who raised this has replied:

Thank you very much for your answer. The proposed change is fine for me.