search

matrix-org / conference-bot

The conductor for your orchestra^Wconference
Apache License 2.0
44 stars 8 forks source link

Support extended room names #210

Closed H-Shay closed 10 months ago

H-Shay commented 10 months ago

The fosdem schedule has a number of rooms with more than word, ie "K.1.105 (La Fontaine)" or "H.1302 (Depage)" and some of the commands were splitting the input args such that the second part of the name was being cut, meaning that the commands were unable to find the rooms.

This PR adds support for rooms with more than one word in them by changing how the args are parsed when the commands are run.

The other option for fixing this would be to strip all the rooms as they are parsed/stored - I considered that as well but this seemed faster - happy to change course if it's incorrect.

reivilibre commented 10 months ago

just as a note of interest, in previous years (or at least last year) these were 'slugified' into k1.1.05_la_fontaine etc or something like that and you'd refer to them by slug.

H-Shay commented 10 months ago

just as a note of interest, in previous years (or at least last year) these were 'slugified' into k1.1.05_la_fontaine etc or something like that and you'd refer to them by slug.

When the room is converted in an auditorium the name as given from the schedule is stored as id, and there is a separate field for the slug (slugified name). The function that looks up the input from the user in Verify and other commands, getAuditorium, looks up the auditorium by auditorium.id rather than auditorium.slug - I see the slug being used in the room aliases, though. So i think this change is still needed?