search

matsengrp / larch

Inference and manipulation of history DAGs
2 stars 2 forks source link

Fitch sets ua refactor #50

Closed davidrich27 closed 1 year ago

davidrich27 commented 1 year ago

Function names replace usage of "root" with usage of "ua" (universal ancestor).

ognian- commented 1 year ago

Looks good, except missing counterpart to IsUA(). I added it, so now IsUA() returns true for the UA node, and IsTreeRoot() returns true for the tree root below UA.

I think it would be nice to also refactor DAG's HaveRoot() and GetRoot() in connections.hpp.