search

matthewwithanm / django-imagekit

Automated image processing for Django. Currently v4.0
http://django-imagekit.rtfd.org/
BSD 3-Clause "New" or "Revised" License
2.26k stars 276 forks source link

Fix `ImageCacheFile.__repr__` to not send signals #435

Closed ron8mcr closed 6 years ago

ron8mcr commented 6 years ago

Cachefile strategy may be configured to generate file when file existance required.

To generate images, async backends passes ImageCacheFile instance to a worker. Both celery and RQ calls __repr__ method for each argument to the enque call. And if __repr__ of the object will send existnace_required signal, we will get endless recursion.

Issue: #434

vstoykov commented 6 years ago

Thank you for your contribution.

ron8mcr commented 6 years ago

@vstoykov thanks! When the next release planned?

vstoykov commented 6 years ago

Currently there is no planned date but I can try to release new bugfix release these days, because there are couple of fixes in develop branch and no new features.