matthewwithanm / django-imagekit

Automated image processing for Django. Currently v4.0
http://django-imagekit.rtfd.org/
BSD 3-Clause "New" or "Revised" License
2.26k stars 276 forks source link

Uniform image extensions #439

Open kukosk opened 6 years ago

kukosk commented 6 years ago

Today I encountered an issue with image file extensions. I uploaded a '.jpeg' file to my Django app, and found out imagekit used that extension also to store the converted image file. I then looked into the lib code, and found out it's actually a desired behaviour (suggest_extension function), but I think it would be better to use default extensions for file formats. I know it's a minor thing, but I don't like the fact that mixed extensions would be used for the same formats just because the user uploads a picture with a different extension. I know this can be fixed by using a different extension in the upload_to attribute, but I'm generating that from the filename of the file the user uploads, so that I can support multiple extensions in some other parts of my app.

Don't you think it would be better to remove the logic that gives precedence to the original extension?