Python 3.6 and Django 2.1

matthewwithanm / django-imagekit

Automated image processing for Django. Currently v4.0

http://django-imagekit.rtfd.org/

BSD 3-Clause "New" or "Revised" License

2.26k stars 276 forks source link

Python 3.6 and Django 2.1 #475

Closed vstoykov closed 5 years ago

vstoykov commented 5 years ago

Stop testing some configurations of older Django versions.
Test aginast Django master
Simplify tox configuration to reduce number of lines.
Simplify travis configuration to reduce number of lines.

vstoykov commented 5 years ago

@matthewwithanm for some reason Travis CI is not running the tests for the PR. Can you check If you have some notifications about it?

KhanMaytok commented 5 years ago

The is not configuration in travis CI for python 3.6

vstoykov commented 5 years ago

@KhanMaytok I used the same settings as I did for mezzanine CMS and Travis is showing me that it has 3.6 https://travis-ci.org/stephenmcd/mezzanine/builds/432399128

KhanMaytok commented 5 years ago

I mean no config for Python 3,6 in this project. I check the .travis.yml file and only find tests until python 3.5

https://github.com/matthewwithanm/django-imagekit/blob/develop/.travis.yml#L62

vstoykov commented 5 years ago

You can't see it in .travis.yml in the develop branch because this is the merge request which is adding the config for Python 3.6.

I totally don't understand your comments.

In other projects on which there was merge requests with changes in .travis.yml file Travis correctly test with the changes for that particular MR.

vstoykov commented 5 years ago

@matthewwithanm I added Travis for my fork of the ImageKit and this change is passing. There is one error for Django master branch but I will fix it later.

More details here https://travis-ci.org/vstoykov/django-imagekit/builds/440777818