Add support of celery 5.*

matthewwithanm / django-imagekit

Automated image processing for Django. Currently v4.0

http://django-imagekit.rtfd.org/

BSD 3-Clause "New" or "Revised" License

2.26k stars 276 forks source link

Add support of celery 5.* #519

Closed riazanovslv closed 3 years ago

riazanovslv commented 3 years ago

Hello, @vstoykov

I have re-created the pull request to make it have only a single commit. I am curios why didn't you want to squash the commits on accepting the pull request? I mean this feature:

vstoykov commented 3 years ago

Thank you for the time to do it manually. I'm not used to this feature in GitHub. In other projects on GitLab I saw this feature. I'm not sure if it is implemented the same or not but then the history is not verry accurate in my opinion. For that reason I prefer the MR to be manually prepared with the number of commits necessary. Some times is better to be only one, other times is better to be split in multiple commits for easy reviewing.

Thank you again for your time.

riazanovslv commented 3 years ago

Thank you for the clarification!