search

matthewwithanm / django-imagekit

Automated image processing for Django. Currently v4.0
http://django-imagekit.rtfd.org/
BSD 3-Clause "New" or "Revised" License
2.27k stars 275 forks source link

Python/Django support policy #535

Closed jaap3 closed 2 years ago

jaap3 commented 3 years ago

First of all, thanks for this project. I've been using it for years and it has survived many Django upgrades and even some Python upgrades. It's been so solid that I hadn't even noticed the hasn't been a new release for over a few years now.

However, today I tried to run a projects test suite with the recently released Django 4.0a1 and faced an ImportError caused by django-imagekit (PR to fix that here: #534).

While making this PR I noticed that this project is only tested on fairly old versions of Python and Django. So I'm wondering, what is the support policy of this project?

Django will drop support for Python < 3.8 with the release of Django 4.0, and has dropped support for Python < 3 a while ago. Even the Python project has stopped supporting Python 2. So I'm wondering if this project could also drop support for Python 2, and maybe even unsupported Django versions.

At the moment of writing the only supported Django versions are 2.2 (LTS), 3.1 and 3.2 (LTS). None of these versions are listed in the tox and travis configs.

I noticed that the underlying pilkit library is tested on more modern set of Python versions, and has switched to GitHub Actions. Would it be appreciated if I made a PR that expanded the test targets to modern Python/Django versions and switched from travis to GitHub actions?

vstoykov commented 3 years ago

Hey @jaap3! First thank you for the interest and usage of the project. I was planning to migrate django-imagekit to GitHub Actions long ago but still didn't have time to do it. I was able just to migrate Pilkit.

If you have the time and you are willing to spend it to migrate to GitHub Actions and also update the the code to test newer versions of Python and Django I will really appreciate it.

I was also planning to remove dependency on six in order to drop the Python 2 support. If you also have interest in this I'll be very glad.

jaap3 commented 2 years ago

@vstoykov I've created PR #536 to switch to GitHub Actions. Any further efforts to modernize this code base would greatly benefit from that PR being merged.

vstoykov commented 2 years ago

I accepted your PR and now we can say that Django Imagekit is Python 3.6+ and Django 2.2+. Do you think we can say that this issue is resolved?

jaap3 commented 2 years ago

I believe this issue is resolved. I hope to find some time today to rip out some of the backwards compatibility code, but that's not part of this ticket.