search

mattmccray / liquid.js

JavaScript port of Tobias Luetke's Liquid template engine.
221 stars 60 forks source link

Extending native JavaScript objects is a bad practice #47

Open mauteri opened 8 years ago

mauteri commented 8 years ago

I noticed in a few spots that JavaScript's native Array and String objects are being extended by Liquid with clear, first, last, etc.

With Liquid on our site, we ran into some pretty nasty bugs due to this and had to roll code back. Is there a reason this needs to be done as a property rather than creating helpers for this functionality? I'd be happy to provide a pull request to change this bit of code.

mauteri commented 8 years ago

Added pull request that just sets enumerable to false to prevent Liquid properties from showing up in for...in loops.

maxfrigge commented 7 years ago

I hit this issue too... would be an easy merge. May I ask why this has not been accepted?

maxfrigge commented 7 years ago

Ok.. so it seems to be fixed in master. Are there any known issues in master?

h0jeZvgoxFepBQ2C commented 6 years ago

Yeah, whats the status of this issue?

mauteri commented 6 years ago

Project looks pretty much abandoned to me... Last commit was December 5, 2016... :-/